Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adhere to delta.checkpoint.writeStatsAsStruct #3207

Open
ion-elgreco opened this issue Feb 11, 2025 · 2 comments · May be fixed by #3209
Open

Adhere to delta.checkpoint.writeStatsAsStruct #3207

ion-elgreco opened this issue Feb 11, 2025 · 2 comments · May be fixed by #3209
Assignees
@ion-elgreco
Labels
bug Something isn't working

Comments

@ion-elgreco
Copy link
Collaborator

We currently always write stats_parsed without checking the delta.checkpoint.writeStatsAsStruct flag on the config. We should check this before writing the stats_parsed.
@ion-elgreco ion-elgreco added the bug Something isn't working label Feb 11, 2025
@ion-elgreco ion-elgreco self-assigned this Feb 11, 2025
@ion-elgreco ion-elgreco linked a pull request Feb 11, 2025 that will close this issue
Open
@Matthieusalor
Copy link

Seems like it would fix part of #3201 - in the case where I would put delta.checkpoint.writeStatsAsStruct to false, is that assumption correct ? Also, shouldn't stat_parsed be limited to list columns in the skipping config ?

@ion-elgreco
Copy link
Collaborator Author

Seems like it would fix part of #3201 - in the case where I would put delta.checkpoint.writeStatsAsStruct to false, is that assumption correct ? Also, shouldn't stat_parsed be limited to list columns in the skipping config ?

Yes.

Regarding the second question indeed, but I will address that in another fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ion-elgreco ion-elgreco

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: adhere write stats configuration ion-elgreco/delta-rs
2 participants
@ion-elgreco @Matthieusalor