Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DMRS updates #174

Closed
goodmami opened this issue Sep 24, 2018 · 2 comments
Closed

DMRS updates #174

goodmami opened this issue Sep 24, 2018 · 2 comments
Milestone

Comments

@goodmami
Copy link
Member

Create a new delphin.dmrs module/package.

  • delphin.dmrs.DMRS class, which is like the current delphin.mrs.xmrs.Dmrs except there should be no conversion to Xmrs structures (it should be natively DMRS), and other irrelevant parts are removed
  • delphin.dmrs.Node class, moved from delphin.mrs.components.Node
  • delphin.dmrs.Link class, moved from delphin.mrs.components.Link
  • delphin.dmrs.ICONSLink class (maybe? maybe rename?) which encodes ICONS information (see this thread: http://lists.delph-in.net/archives/developers/2018/002786.html)
  • delphin.dmrs.dmrx moved from delphin.mrs.dmrx
  • delphin.dmrs.simpledmrs moved from delphin.mrs.simpledmrs

Until v1.0.0, existing imports should not be broken if possible (see #139)

@goodmami goodmami added this to the v0.10.0 milestone Sep 24, 2018
@goodmami
Copy link
Member Author

goodmami commented Oct 27, 2018

More info:

  • the DMRS class does not inherit from XMRS, but should be able to convert to and from it when necessary (e.g., for DMRS to MRS conversion). The other classes (MRS and EDS) will do this as well.
  • the format-specific conversion methods to_dict(), from_dict(), to_triples(), and from_triples() will be moved to the format modules (e.g., delphin.dmrs.dmrsjson and delphin.dmrs.dmrspenman (and, again, likewise for other representations). The reasons for this are:
    • the classes were getting cluttered with conversion code
    • we may want different versions (e.g., dmrsrdf.to_triples() or something)
    • this way they can be proper codecs with load(), dump(), etc.
  • DMRS-specific constants (e.g., EQ_POST, etc.) get moved to the delphin.dmrs package

@goodmami goodmami modified the milestones: v0.10.0, v1.0.0 Nov 26, 2018
@goodmami
Copy link
Member Author

I moved the ICONS stuff to #220, so this issue is now complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant