Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash when calling label.set_text addressing a game object with multiple labels #8555

Open
redoak opened this issue Feb 18, 2024 · 0 comments · May be fixed by #8580
Open

Crash when calling label.set_text addressing a game object with multiple labels #8555

redoak opened this issue Feb 18, 2024 · 0 comments · May be fixed by #8580
Labels
bug Something is not working as expected engine Issues related to the Defold engine label Issues related to labels

Comments

@redoak
Copy link
Contributor

redoak commented Feb 18, 2024 •
edited

Describe the bug (REQUIRED)
If a game object has multiple labels, calling label.set_text addressing the game object will cause a crash.

To Reproduce (REQUIRED)
Steps to reproduce the behavior:

  1. Run the linked project, or
  2. Add a game object with a script and two labels
  3. In the script, call label.set_text('.', 'my text')
  4. Run and see crash

Expected behavior (REQUIRED)
The text of all or the first encountered label should be set.

Defold version (REQUIRED):

  • Version 1.6.4

Platforms (REQUIRED):

  • Platforms: Windows
  • OS: Windows 10
  • Device: None

Minimal repro case project (OPTIONAL):
Repo: https://github.com/redoak/defold-label-set-text-crash
Crash dump: _crash.zip

Logs (OPTIONAL):

Console log 
INFO:DLIB: Log server started on port 51200
INFO:ENGINE: Target listening with name: HIDDEN
INFO:ENGINE: Engine service started on port 51201
INFO:GRAPHICS: Installed graphics device 'ADAPTER_FAMILY_OPENGL'
INFO:ENGINE: Defold Engine 1.6.4 (fcec950)
INFO:DLIB: Initialized Remotery (ws://127.0.0.1:17815/rmt)
INFO:ENGINE: Loading data from: build/default
INFO:ENGINE: Initialised sound device 'default'
INFO:CRASH: Successfully wrote Crashdump to file: C:\Users\HIDDEN\AppData\Roaming\Defold/_crash
ERROR:CRASH: CALL STACK:

ERROR:CRASH:  0 0x7FF79E4C6590 dmCrash::GenerateCallstack D:\a\defold\defold\engine\crash\src\backtrace_win32.cpp:144

ERROR:CRASH:  1 0x7FF79E5BD2EC _seh_filter_exe minkernel\crts\ucrt\src\appcrt\misc\exception_filter.cpp:219

ERROR:CRASH:  2 0x7FF79E601E94 `__scrt_common_main_seh'::`1'::filt$0 D:\a\_work\1\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:304

ERROR:CRASH:  3 0x7FF79E53E52C __C_specific_handler D:\a\_work\1\s\src\vctools\crt\vcruntime\src\eh\riscchandler.cpp:389

ERROR:CRASH:  4 0x7FF8CCAB2290 __chkstk <unknown>:0

ERROR:CRASH:  5 0x7FF8CCA61030 RtlRaiseException <unknown>:0

ERROR:CRASH:  6 0x7FF8CCAB0E90 KiUserExceptionDispatcher <unknown>:0

ERROR:CRASH:  7 0x7FF79E5C3144 _strdup minkernel\crts\ucrt\src\appcrt\string\strdup.cpp:44

ERROR:CRASH:  8 0x7FF79E202FA0 dmGameSystem::CompLabelOnMessage D:\a\defold\defold\engine\gamesys\src\gamesys\components\comp_label.cpp:544

ERROR:CRASH:  9 0x7FF79E135090 dmGameObject::DispatchMessagesFunction D:\a\defold\defold\engine\gameobject\src\gameobject\gameobject.cpp:2376

ERROR:CRASH: 10 0x7FF79E3E77A0 dmMessage::InternalDispatch D:\a\defold\defold\engine\dlib\src\dlib\message.cpp:573

ERROR:CRASH: 11 0x7FF79E1395D0 dmGameObject::InitCollection D:\a\defold\defold\engine\gameobject\src\gameobject\gameobject.cpp:1776

ERROR:CRASH: 12 0x7FF79E118610 dmEngine::Init D:\a\defold\defold\engine\engine\src\engine.cpp:1311

ERROR:CRASH: 13 0x7FF79E11D070 dmEngineCreate D:\a\defold\defold\engine\engine\src\engine.cpp:2120

ERROR:CRASH: 14 0x7FF79E11D600 dmEngine::RunLoop D:\a\defold\defold\engine\engine\src\engine_loop.cpp:68

ERROR:CRASH: 15 0x7FF79E115A70 engine_main D:\a\defold\defold\engine\engine\src\engine_main.cpp:148

ERROR:CRASH: 16 0x7FF79E532924 __scrt_common_main_seh D:\a\_work\1\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:288

ERROR:CRASH: 17 0x7FF8CAED7330 BaseThreadInitThunk <unknown>:0

ERROR:CRASH: 18 0x7FF8CCA62690 RtlUserThreadStart <unknown>:0

ERROR:CRASH: 

INFO:CRASH: Successfully wrote Crashdump to file: C:\Users\HIDDEN\AppData\Roaming\Defold/_crash
ERROR:CRASH: CALL STACK:

ERROR:CRASH:  0 0x7FF79E5C3144 _strdup minkernel\crts\ucrt\src\appcrt\string\strdup.cpp:44

ERROR:CRASH:  1 0x7FF79E202FA0 dmGameSystem::CompLabelOnMessage D:\a\defold\defold\engine\gamesys\src\gamesys\components\comp_label.cpp:544

ERROR:CRASH:  2 0x7FF79E135090 dmGameObject::DispatchMessagesFunction D:\a\defold\defold\engine\gameobject\src\gameobject\gameobject.cpp:2376

ERROR:CRASH:  3 0x7FF79E3E77A0 dmMessage::InternalDispatch D:\a\defold\defold\engine\dlib\src\dlib\message.cpp:573

ERROR:CRASH:  4 0x7FF79E1395D0 dmGameObject::InitCollection D:\a\defold\defold\engine\gameobject\src\gameobject\gameobject.cpp:1776

ERROR:CRASH:  5 0x7FF79E118610 dmEngine::Init D:\a\defold\defold\engine\engine\src\engine.cpp:1311

ERROR:CRASH:  6 0x7FF79E11D070 dmEngineCreate D:\a\defold\defold\engine\engine\src\engine.cpp:2120

ERROR:CRASH:  7 0x7FF79E11D600 dmEngine::RunLoop D:\a\defold\defold\engine\engine\src\engine_loop.cpp:68

ERROR:CRASH:  8 0x7FF79E115A70 engine_main D:\a\defold\defold\engine\engine\src\engine_main.cpp:148

ERROR:CRASH:  9 0x7FF79E532924 __scrt_common_main_seh D:\a\_work\1\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:288

ERROR:CRASH: 10 0x7FF8CAED7330 BaseThreadInitThunk <unknown>:0

ERROR:CRASH: 11 0x7FF8CCA62690 RtlUserThreadStart <unknown>:0

ERROR:CRASH: 

INFO:CRASH: Successfully wrote MiniDump to file: C:\Users\HIDDEN\AppData\Roaming\Defold/_crash.dmp

Workaround (OPTIONAL):
It works as expected if the label fragment is addressed directly.
@redoak redoak added the bug Something is not working as expected label Feb 18, 2024
@britzl britzl added the label Issues related to labels label Feb 22, 2024
@britzl britzl linked a pull request Feb 22, 2024 that will close this issue
Draft
14 tasks
@AGulev AGulev added the engine Issues related to the Defold engine label May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something is not working as expected engine Issues related to the Defold engine label Issues related to labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prevent crash when setting label text on a game object with multiple labels defold/defold
3 participants
@britzl @AGulev @redoak