Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarification on Code Implementation in DeepSeek vs Llama #53

Open
dog14230pp opened this issue Oct 7, 2024 · 0 comments
Open

Clarification on Code Implementation in DeepSeek vs Llama #53

dog14230pp opened this issue Oct 7, 2024 · 0 comments

Comments

@dog14230pp
Copy link

Dear Authors,

Thank you for providing such excellent work for the community to use!

I have a question regarding an implementation detail. In Line 338, it appears that the code is adapted from Llama. However, when looking closer, the implementation in DeepSeek seems to differ, particularly from Line 363 to Line 367, compared to Llama’s implementation in Line 223.

Could you explain the reasoning behind this difference? Were there specific considerations that led to this change?

I look forward to your response. Thank you again for your great work!

Best regards,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant