fix to return combined multiple errors

[eyasy1217]

closes #1515

MarshalJSON returns combined json marshal errors in AdditionalProperties.

e.g.

Before
error marshaling 'unsupportedType1': json: unsupported type: chan int
↓
After
error marshaling 'unsupportedType1': json: unsupported type: chan int 'unsupportedType2': json: unsupported type: func()

(requierd go 1.20)

[jamietanna]

Thanks for this!

I was wondering if maybe instead of this, we have i.e.

	var errs []error
	for fieldName, field := range a.AdditionalProperties {
		object[fieldName], err := json.Marshal(field)
		if err != nil {
			errs = append(errs, fmt.Errorf("'%s': %w", fieldName, err))
		}
	}
	err := errors.Join(errs...)
	if err != nil {
		return nil, fmt.Errorf("error marshaling %w", joinedError)
	}

Which then uses errors.Join in a slightly easier way?

[eyasy1217]

Thanks for this!

I was wondering if maybe instead of this, we have i.e.

	var errs []error
	for fieldName, field := range a.AdditionalProperties {
		object[fieldName], err := json.Marshal(field)
		if err != nil {
			errs = append(errs, fmt.Errorf("'%s': %w", fieldName, err))
		}
	}
	err := errors.Join(errs...)
	if err != nil {
		return nil, fmt.Errorf("error marshaling %w", joinedError)
	}

Which then uses errors.Join in a slightly easier way?

It looks to me like this is doing something similar to the internal code of errors.Join
🤔

[jamietanna]

Yep, but with an array rather than joining in the loop will probably be a little more efficient, and only does the joining once

[eyasy1217]

That's right.
🚀 52f6cdc

[gaiaz-iusipov]

I think the same behavior can be achieved as follows:

var errs error
for fieldName, field := range a.AdditionalProperties {
	object[fieldName], err = json.Marshal(field)
	if err != nil {
		errs = errors.Join(errs, fmt.Errorf("json marshal %q: %w", fieldName, err))
	}
}
if errs != nil {
	return nil, errs
}