refactor: simplify IsPredeclaredGoIdentifier

pkg/codegen/utils.go

@@ -15,6 +15,7 @@ package codegen
 
 import (
  "fmt"
+ "go/doc"
  "go/token"
  "net/url"
  "reflect"
@@ -28,64 +29,13 @@ import (
 )
 
 var (
- pathParamRE *regexp.Regexp
- predeclaredSet map[string]struct{}
- separatorSet map[rune]struct{}
+ pathParamRE *regexp.Regexp
+ separatorSet map[rune]struct{}
 )
 
 func init() {
  pathParamRE = regexp.MustCompile(`{[.;?]?([^{}*]+)\*?}`)
 
- predeclaredIdentifiers := []string{
- // Types
- "bool",
- "byte",
- "complex64",
- "complex128",
- "error",
- "float32",
- "float64",
- "int",
- "int8",
- "int16",
- "int32",
- "int64",
- "rune",
- "string",
- "uint",
- "uint8",
- "uint16",
- "uint32",
- "uint64",
- "uintptr",
- // Constants
- "true",
- "false",
- "iota",
- // Zero value
- "nil",
- // Functions
- "append",
- "cap",
- "close",
- "complex",
- "copy",
- "delete",
- "imag",
- "len",
- "make",
- "new",
- "panic",
- "print",
- "println",
- "real",
- "recover",
- }
- predeclaredSet = map[string]struct{}{}
- for _, id := range predeclaredIdentifiers {
- predeclaredSet[id] = struct{}{}
- }
-
  separators := "-#@!$&=.+:;_~ (){}[]"
  separatorSet = map[rune]struct{}{}
  for _, r := range separators {
@@ -573,8 +523,7 @@ func IsGoKeyword(str string) bool {
 //
 // See https://golang.org/ref/spec#Predeclared_identifiers
 func IsPredeclaredGoIdentifier(str string) bool {
- _, exists := predeclaredSet[str]
- return exists
+ return doc.IsPredeclared(str)
 }
 
 // IsGoIdentity checks if the given string can be used as an identity

pkg/codegen/utils_test.go

@@ -608,3 +608,23 @@ func Test_replaceInitialisms(t *testing.T) {
  })
  }
 }
+
+func TestIsPredeclaredGoIdentifier(t *testing.T) {
+ type args struct {
+ s string
+ }
+ tests := []struct {
+ name string
+ args args
+ want bool
+ }{
+ {name: "empty string", args: args{s: ""}, want: false},
+ {name: "not predeclared", args: args{s: "foo"}, want: false},
+ {name: "predeclared", args: args{s: "any"}, want: true},
+ }
+ for _, tt := range tests {
+ t.Run(tt.name, func(t *testing.T) {
+ assert.Equal(t, tt.want, IsPredeclaredGoIdentifier(tt.args.s))
+ })
+ }
+}