Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: call transformError when error is thrown outside of actions #611

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

refactor: call transformError when error is thrown outside of actions #611

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/rpc/src/protocol.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -737,5 +737,9 @@ export function rpcDecodeError(error: EncodedError): Error {
const e = new Error(error.message);
e.stack = error.stack + '\nat ___SERVER___';

if(error.stack === "") {
e.stack = ""
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this does not include errors that are nominally thrown like these (since it early exits at line 730)

@entity.name('@error:user')
class UserNotFound extends Error{}

while looking at that code I really wonder if we get then even a good stack trace at all even within the client. it seems the new e.stack = '' and the old e.stack = error.stack ... just drops all the information, which is not good. we likely want to maintain the actual stack trace on the client side so users see in what code the error was thrown

return e;
}
2 changes: 1 addition & 1 deletion packages/rpc/src/server/kernel.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -528,7 +528,7 @@ export class RpcKernelConnection extends RpcKernelBaseConnection {
return await this.actionHandler.handle(message, response);
}
} catch (error: any) {
response.error(error);
response.error(this.security.transformError(error));
}
}

Expand Down
30 changes: 30 additions & 0 deletions packages/rpc/tests/security.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,36 @@ test('authentication errors', async () => {
expect(memoryLogger.messages.length).toBe(1);
});

test('authentication errors and calls transformError', async () => {
let transformedError: Error | null = null;

class MyKernelSecurity extends RpcKernelSecurity {
async authenticate(token: any): Promise<Session> {
throw new Error('Malformed token');
}

override transformError(err: Error) {
transformedError = new Error("Transformed");
transformedError.stack = "";
return transformedError;
}
}

const kernel = new RpcKernel([{ provide: RpcKernelSecurity, useClass: MyKernelSecurity, scope: 'rpc' }]);
const client = new DirectClient(kernel);

client.token.set('generic');

try {
await client.connect()
} catch(e: any) {
expect(e.stack).toBe('');
}

expect(transformedError).toBeInstanceOf(Error);
expect(transformedError!.message).toBe('Transformed');
});


test('onAuthenticate controllers', async () => {
class AuthenticatedSession extends Session {
Expand Down
Loading