Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP: compression should not be enabled by default #592

Open
alpharder opened this issue Jul 6, 2024 · 1 comment
Open

HTTP: compression should not be enabled by default #592

alpharder opened this issue Jul 6, 2024 · 1 comment

Comments

@alpharder
Copy link
Contributor

alpharder commented Jul 6, 2024

The worst task JS could do is compression.
It's usually better handled by ingress servers such as Nginx, Caddy or Traefik.

I would ditch compression from the framework completely or it should be at least disabled by default.

See FrameworkConfig,

    /**
     * The compression level to use when using the zlib module.
     * 0 means no compression, and 9 is the maximum compression.
     */
    compression: number = 6;
@marcj
Copy link
Member

marcj commented Jul 6, 2024

it's fine, not everyone needs a reverse proxy and has low load, for these use-cases we keep it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants