Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Types for registerWidget don't match the implementation #7410

Open
fgnass opened this issue Feb 24, 2025 · 0 comments · May be fixed by #7411
Open

Types for registerWidget don't match the implementation #7410

fgnass opened this issue Feb 24, 2025 · 0 comments · May be fixed by #7411
Labels
type: bug code to address defects in shipped code

Comments

@fgnass
Copy link
Contributor

fgnass commented Feb 24, 2025

Describe the bug

The types for registerWidget only specify a single signature, but the implementation allows two additional ways of registering widgets, which are both actively used throughout the codebase.

Why this matters

Currently, decap-cms-app registers all widgets eagerly at once, which results in very large bundle sizes. I would like to provide an alternative, more modular approach, but this requires the types to match in the first place.

What to do

Stay tuned for a PR or possibly an update to #7402

@fgnass fgnass added the type: bug code to address defects in shipped code label Feb 24, 2025
fgnass added a commit to fgnass/decap-cms that referenced this issue Feb 24, 2025
fgnass added a commit to fgnass/decap-cms that referenced this issue Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug code to address defects in shipped code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant