Improve the memory efficiency of process_results() override #1050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-snowflake contributing guide. |
aranke
reviewed
May 17, 2024
| for row in rows: | ||
| fixed_row = [] | ||
| for col in row: | ||
| if isinstance(col, datetime.datetime) and col.tzinfo: | ||
| offset = col.utcoffset() | ||
| assert offset is not None | ||
| offset_seconds = offset.total_seconds() |
There was a problem hiding this comment.
Nit: offset_seconds = offset.total_seconds() or 0
| offset_seconds = offset.total_seconds() | ||
| new_timezone = pytz.FixedOffset(offset_seconds // 60) | ||
| new_timezone = pytz.FixedOffset(int(offset_seconds // 60)) |
There was a problem hiding this comment.
pytz is no longer required as of 3.9+, let's try to remove the dependency here?
https://github.com/stub42/pytz/blob/master/src/README.rst#introduction
mikealfare
reviewed
May 17, 2024
mikealfare
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1053
Problem
The existing override of process_results() creates a full copy of query results.
Solution
Iterate over result rows to modify them one by one.
Checklist