Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Bad argument sent to logging in tracking function #9753

Open
2 tasks done
pol-defont-reaulx opened this issue Mar 12, 2024 · 3 comments · May be fixed by #9754
Open
2 tasks done

[Bug] Bad argument sent to logging in tracking function #9753

pol-defont-reaulx opened this issue Mar 12, 2024 · 3 comments · May be fixed by #9754
Labels
bug Something isn't working Medium Severity bug with minor impact that does not have resolution timeframe requirement

Comments

@pol-defont-reaulx
Copy link

Is this a new bug in dbt-core?

  • I believe this is a new bug in dbt-core
  • I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior

In core/dbt/tracking.py, the string argument sent to _log_result for http_post is not the right one. It's "GET".

Expected Behavior

The argument sent should be "POST"

Steps To Reproduce

In the code

Relevant log output

No response

Environment

No response

Which database adapter are you using with dbt?

No response

Additional Context

No response
@pol-defont-reaulx pol-defont-reaulx added bug Something isn't working triage labels Mar 12, 2024
@pol-defont-reaulx pol-defont-reaulx linked a pull request Mar 12, 2024 that will close this issue
Open
5 tasks
@dbeatty10
Copy link
Contributor

Thanks for opening an issue and PR (#9754) for this @pol-defont-reaulx !

What are the consequence(s) and/or impact of GET vs. POST?

@pol-defont-reaulx
Copy link
Author

The consequence is a bad labelling of the request's type when pushing logs to Snowplow for POST requests. It's not a critical bug at all of course.

@dbeatty10
Copy link
Contributor

Makes sense!

@dbeatty10 dbeatty10 added Medium Severity bug with minor impact that does not have resolution timeframe requirement and removed triage labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working Medium Severity bug with minor impact that does not have resolution timeframe requirement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: bad argument passed in tracking _log_result pol-defont-reaulx/dbt-core
2 participants
@dbeatty10 @pol-defont-reaulx