Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for SecretBinary #1043

Open
avpjanm opened this issue Jun 13, 2024 · 1 comment
Open

Support for SecretBinary #1043

avpjanm opened this issue Jun 13, 2024 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@avpjanm
Copy link

avpjanm commented Jun 13, 2024

First of all thanks a lot for this construct!

I am just wondering whether it is possible to create binary secrets. For example key stores.
I kind of got the idea from the readme:

Binary - Just the raw file[...]

But when I tried this it could see some string value of the secret in the console which is not the case for binary secrets.

@markussiebert
Copy link
Contributor

markussiebert commented Jun 14, 2024

At the moment we use it already for keys, but handle them as 'strings' in the aws call. I agree we should add an option to pass the secret as binary (maybe this should be the default if option binary is used)

@markussiebert markussiebert added enhancement New feature or request help wanted Extra attention is needed labels Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants