Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search Function Not Highlighting Correct Schema #29280

Closed
ufuk-ergin-carbon opened this issue Apr 30, 2024 · 15 comments
Closed

Search Function Not Highlighting Correct Schema #29280

ufuk-ergin-carbon opened this issue Apr 30, 2024 · 15 comments
Labels

Comments

@ufuk-ergin-carbon
Copy link

ufuk-ergin-carbon commented Apr 30, 2024

Description

The search function in the Dbeaver does not work correctly. I am not sure if it is the intended outcome but as the way it is, it is very useless. When you search for a table name, it highlights the wrong schema and you'd have guess to expand tables. It does not narrow it down for you. I am attaching a screen recording for the behavior. I am also attaching a screen recording as to how it should be in Snowflake's own editor window.

Screen.Recording.2024-04-30.at.13.55.55.mov
Screen.Recording.2024-04-30.at.13.58.58.mov

Edit: This has been going on for a long time. Not a new issue.

DBeaver Version

CE Version 24.0.3.202404211624

Operating System

MacOs Sonoma 14.4.1 (23E224)

Database and driver

Snowflake Server: Snowflake 8.16.10
Driver: Snowflake 3.14.4

Steps to reproduce

No response

Additional context

No response

@E1izabeth
Copy link
Member

Could you clarify what the issue is? Where do you expect to meet highlighting?
Filtering removes all elements from the navigator, which doesn't correspond to the condition.

@ufuk-ergin-carbon
Copy link
Author

Hello @E1izabeth , when you search for a table name for example, the search should filter as to where the navigator found the search string. This is what happens in Snowflake UI (the second screen recording). However, in Dbeaver, it does not do anything when you copy and past the table name and hit return in the search bar. It does not tell you where it found the table, it does not filter, in the video, I have to guess where it could have been and expand it. Does it make sense?

@E1izabeth
Copy link
Member

I see. Thank you for explanation. The difference is that it's a filter, not search. That's why it works differently. We will discuss your suggestion to improve this behavior.
I may suggest you to use search this way:

  1. Use shortcut ⌃⇧D to open search dialog
    image

OR
2) Use Metadata search from the main toolbar
image

Here is how it look like

image

@ufuk-ergin-carbon
Copy link
Author

ufuk-ergin-carbon commented Apr 30, 2024

The Metasearch from the main toolbar does not work or I am missing something. I am attaching the screen recording:

Screen.Recording.2024-04-30.at.17.00.24.mov

And, the shortcut ⌃⇧D does not provide the full addresses, catalog names are missing (jumps to schema):

Screen.Recording.2024-04-30.at.17.04.53.mov

Also, while it is searching, it does not indicate whether or not it is searching (but it actually is in the background and OK button is disabled). Does your version indicate something like "Searching..."?

@E1izabeth
Copy link
Member

E1izabeth commented Apr 30, 2024

Also, while it is searching, it does not indicate whether or not it is searching (but it actually is in the background and OK button is disabled). Does your version indicate something like "Searching..."?

Yes. It's here
image

@E1izabeth
Copy link
Member

The Metasearch from the main toolbar does not work or I am missing something.

It works after you press Search button. For me it works this way

java_H7W2oMfKQg.mp4

@ufuk-ergin-carbon
Copy link
Author

ufuk-ergin-carbon commented Apr 30, 2024

I cannot hit the Search button because it is disabled. I am attaching the screen recording again. Nothing happens.

Screen.Recording.2024-04-30.at.17.00.24.mov

@E1izabeth
Copy link
Member

I see. Thank you.
The issue here is that Object Types field is empty for you.
Could you provide log files? You can find instructions here https://dbeaver.com/docs/wiki/Log-files/.

@ufuk-ergin-carbon
Copy link
Author

there are multiple log files, but I am attaching one. Let me know if need some others.

Also, do I need to do anything to fix the Object Types field being empty?

dbeaver-debug.log

@E1izabeth
Copy link
Member

Nothing in logs. It looks like a bug, that this field is empty for you. I'm not sure it can be fixed from your side.

@E1izabeth
Copy link
Member

Could you send .log file also?

@ufuk-ergin-carbon
Copy link
Author

dbeaver-debug-1714487425196.log

Does this work for you?

@E1izabeth
Copy link
Member

Seems there is no error to see it in logs.
Could you create Sample SQLite database and check if it works with SQLite for you?
image

@E1izabeth
Copy link
Member

I cannot hit the Search button because it is disabled. I am attaching the screen recording again. Nothing happens.
Screen.Recording.2024-04-30.at.17.00.24.mov

Have you clicked on the connection item here in the video? Maybe it's just not selected

@ufuk-ergin-carbon
Copy link
Author

@E1izabeth , yes, after double clicking and selecting it the Object Type section became available and now it works as it should. Thanks for the help. Appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants