Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more keywords for smart block recognition #29279

Closed
E1izabeth opened this issue Apr 30, 2024 · 3 comments · Fixed by #29284
Closed

Add more keywords for smart block recognition #29279

E1izabeth opened this issue Apr 30, 2024 · 3 comments · Fixed by #29284
Assignees
@E1izabeth @uslss
Labels
enhancement sp:1 xf:sql editor SQL Editor and Editor Services like autocompletion, highlighting, folding, formatting, etc.
Milestone
24.0.5

Comments

@E1izabeth
Copy link
Member

image
We should improve our query start recognition mechanism to handle such cases.
@E1izabeth E1izabeth added enhancement sp:1 xf:sql editor SQL Editor and Editor Services like autocompletion, highlighting, folding, formatting, etc. labels Apr 30, 2024
@E1izabeth E1izabeth added this to the 24.0.5 milestone Apr 30, 2024
@E1izabeth E1izabeth self-assigned this Apr 30, 2024
@mbezhanov
Copy link

mbezhanov commented Apr 30, 2024 •
edited

I am currently being affected by this:

image

The GRANT statement is being grouped with the CREATE statement and the two are being sent together to the SQL server.

From the execution log:

Time: Apr-30 13:19:39
Type: SQL / User script
Text: CREATE USER 'test'@'%' IDENTIFIED BY 'test';GRANT ALL ON test.* TO 'test'@'%'
Duration: 105
Result: [1064] You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'GRANT ALL ON test.* TO 'test'@'%'' at line 2

Would be great to have it resolved!

@E1izabeth
Copy link
Member Author

The fix for your case will be included in DBeaver 24.0.4.
Also you can try Early Access version with fix https://dbeaver.io/files/ea/ now.

@mbezhanov
Copy link

Awesome, thank you!

E1izabeth added a commit that referenced this issue Apr 30, 2024
@E1izabeth
#29279 Get keywords from blockBoundStrings for statement start detect…
0173e55 
…ion for `Smart` mode of `Blank line is a statement delimiter` setting
@E1izabeth E1izabeth linked a pull request Apr 30, 2024 that will close this issue
#29279 Get keywords from blockBoundStrings for statement start detect… #29284
Merged
@uslss uslss self-assigned this May 7, 2024
serge-rider pushed a commit that referenced this issue May 7, 2024
@E1izabeth
#29279 Get keywords from blockBoundStrings for statement start detect…
915220a 
…ion for `Smart` mode of `Blank line is a statement delimiter` setting (#29284)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@E1izabeth E1izabeth

@uslss uslss

Labels
enhancement sp:1 xf:sql editor SQL Editor and Editor Services like autocompletion, highlighting, folding, formatting, etc.
Projects
None yet
Milestone
24.0.5
Development

Successfully merging a pull request may close this issue.

#29279 Get keywords from blockBoundStrings for statement start detect… dbeaver/dbeaver
3 participants
@mbezhanov @E1izabeth @uslss