From 800600a6091dda80c2eadb6e43bf0737476dbd0c Mon Sep 17 00:00:00 2001 From: Maximilian Franzke Date: Sat, 3 Aug 2024 20:02:53 +0200 Subject: [PATCH 1/3] refactor: replaced by simpler solution --- .../src/components/navigation/navigation.scss | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/packages/components/src/components/navigation/navigation.scss b/packages/components/src/components/navigation/navigation.scss index b449ca727d6..05fb42d1193 100644 --- a/packages/components/src/components/navigation/navigation.scss +++ b/packages/components/src/components/navigation/navigation.scss @@ -80,20 +80,11 @@ } } } + } - &:has([aria-current="page"]), + > .db-navigation-item { &[aria-current="page"] { @extend %show-db-puls-auto; - - menu { - // hide puls for non navigation items - :has([aria-current="page"]), - [aria-current="page"] { - &::after { - display: none; - } - } - } } } } From e0eb7389010eb22821cda4f9fe9a9784d5bff612 Mon Sep 17 00:00:00 2001 From: Maximilian Franzke Date: Mon, 5 Aug 2024 08:06:07 +0200 Subject: [PATCH 2/3] test: updated screenshot --- .../DBNavigation-should-match-screenshot.png | Bin 32450 -> 32464 bytes 1 file changed, 0 insertions(+), 0 deletions(-) diff --git a/__snapshots__/navigation/showcase/chromium-highContrast/regular/neutral-bg-lvl-1/DBNavigation-should-match-screenshot.png b/__snapshots__/navigation/showcase/chromium-highContrast/regular/neutral-bg-lvl-1/DBNavigation-should-match-screenshot.png index 87bcafc658399575af9fea30d3af0fe4019221f9..d38750c5ee96bfa4f6f2b5c8a1dcbd899c191591 100644 GIT binary patch delta 70 zcmX@~m+``1#tGtFsT@oU3=Ekk{{G#lXp+E~wmB>zSc=;LD8``hF`)q!L@UHx3vIVCg!0CS%gR{#J2 delta 69 zcmcccm+{bF#tGtFi5yG}3=E$l_rKn#Xp+Dfu{kUuSc=;ND8``h;(vDdjg1R`FpJ$_ XZL8X@GwsE@Dv*SytDnm{r-UW|l%g6W From f5eaa2e787b97a245b2dd129a8a35ccaf5986360 Mon Sep 17 00:00:00 2001 From: Maximilian Franzke <787658+mfranzke@users.noreply.github.com> Date: Wed, 21 Aug 2024 18:36:18 +0200 Subject: [PATCH 3/3] Update navigation.scss --- packages/components/src/components/navigation/navigation.scss | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/packages/components/src/components/navigation/navigation.scss b/packages/components/src/components/navigation/navigation.scss index 05fb42d1193..efb10f20c96 100644 --- a/packages/components/src/components/navigation/navigation.scss +++ b/packages/components/src/components/navigation/navigation.scss @@ -80,9 +80,8 @@ } } } - } - > .db-navigation-item { + &:has([aria-current="page"]), &[aria-current="page"] { @extend %show-db-puls-auto; }