Skip to content

Commit

Permalink
fix: issue with dependencies for angular builds (#246)
Browse files Browse the repository at this point in the history
* fix: issue with dependencies for angular builds
  • Loading branch information
nmerget authored Jan 24, 2023
1 parent 2f184b5 commit 95c1224
Show file tree
Hide file tree
Showing 4 changed files with 174 additions and 130 deletions.
6 changes: 1 addition & 5 deletions .github/scripts/publish-npm.sh
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,7 @@ do

if [[ $PACKAGE != 'foundations' ]]; then
echo "🕵️‍ Set foundations dependency"
if [[ $PACKAGE == 'ngx-components' ]]; then
npm pkg set peerDependencies.@db-ui/foundations="$VALID_SEMVER_VERSION" --workspace=@db-ui/"$PACKAGE"
else
npm pkg set dependencies.@db-ui/foundations="$VALID_SEMVER_VERSION" --workspace=@db-ui/"$PACKAGE"
fi
npm pkg set dependencies.@db-ui/foundations="$VALID_SEMVER_VERSION" --workspace=@db-ui/"$PACKAGE"
fi

echo "📦 Create npm package"
Expand Down
3 changes: 2 additions & 1 deletion output/angular/ng-package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,6 @@
"lib": {
"entryFile": "src/index.ts"
},
"assets": ["src/components/**/*.scss"]
"assets": ["src/components/**/*.scss"],
"allowedNonPeerDependencies": ["@db-ui/foundations"]
}
22 changes: 3 additions & 19 deletions output/angular/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -35,28 +35,12 @@
"module": "dist/fesm5.js",
"main": "dist/fesm5.js",
"types": "dist/core.d.ts",
"peerDependencies": {
"@db-ui/foundations": "*",
"@angular/animations": "~14.2.12",
"@angular/common": "~14.2.12",
"@angular/compiler": "~14.2.12",
"@angular/core": "~14.2.12",
"@angular/forms": "~14.2.12",
"@angular/platform-browser": "~14.2.12",
"@angular/platform-browser-dynamic": "~14.2.12",
"rxjs": "~7.4.0",
"tslib": "^2.4.1",
"zone.js": "~0.11.4"
"dependencies": {
"@db-ui/foundations": "*"
},
"devDependencies": {
"@angular-devkit/build-angular": "~14.2.10",
"@angular/cli": "~14.2.10",
"@angular/compiler-cli": "~14.2.12",
"@types/estree": "^1.0.0",
"@types/node": "^18.11.18",
"ng-packagr": "14.2.2",
"schematics-scss-migrate": "^1.3.15",
"typescript": "~4.8.4"
"ng-packagr": "14.2.2"
},
"files": [
"dist/"
Expand Down
Loading

0 comments on commit 95c1224

Please sign in to comment.