Skip to content

Commit 1683b47

Browse files
mfranzkejonaskuskenmerget
authored
refactor: adapt changes out of release 3.0.0 by DB UI core (#2710)
* refactor: updated DB UI Core version * refactor: adapted the HTML changes out of DB UI Core * fix(chip): remove aria-hidden to expose label in a11y tree (#2659) Co-authored-by: Maximilian Franzke <[email protected]> * refactor: updated snapshots * chore: update snapshots * refactor: we need to ignore the h function import * refactor: updated to DB UI Core Version 3.3.4 * refactor: downgraded zone.js to prevent a conflict * refactor: regenerated package lock file * refactor: added relevant field * fix: structure * docs: added documentation on the regeneration of snapshots * test: updated snapshots * refactor: optimized build * Update README.md * refactor: reverted screenshot * refactor: reverted screenshots * refactor: shouldn't include a paragraph * refactor: removed obsolete declaration --------- Co-authored-by: Jonas Kuske <[email protected]> Co-authored-by: Nicolas Merget <[email protected]>
1 parent 0500ac3 commit 1683b47

File tree

20 files changed

+76
-136
lines changed

20 files changed

+76
-136
lines changed

‎e2e/cypress/e2e/README.md

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
# Regenerate snapshots
2+
3+
In case that your snapshot tests fail, you would need to regenerate the snapshots.
4+
5+
```bash
6+
npm run start
7+
```
8+
9+
and in parallel:
10+
11+
```bash
12+
npm run cypress:snapshot:base
13+
```

‎package-lock.json

Lines changed: 8 additions & 8 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,5 +73,6 @@
7373
"publishConfig": {
7474
"registry": "https://registry.npmjs.org/"
7575
},
76-
"homepage": "https://db-ui.github.io/elements/"
76+
"homepage": "https://db-ui.github.io/elements/",
77+
"packageManager": "[email protected]"
7778
}

‎packages/db-ui-elements-angular/projects/lib/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@
22
"name": "lib",
33
"version": "0.0.1",
44
"peerDependencies": {
5-
"@angular/common": "^17.3.11",
6-
"@angular/core": "^17.3.11"
5+
"@angular/common": "^17.3.12",
6+
"@angular/core": "^17.3.12"
77
},
88
"dependencies": {
99
"tslib": "^2.6.3"

‎packages/db-ui-elements-stencil/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@
4545
"puppeteer": "^24.0.0"
4646
},
4747
"dependencies": {
48-
"@db-ui/core": "^2.22.0"
48+
"@db-ui/core": "^3.3.4"
4949
},
5050
"license": "Apache-2.0",
5151
"publishConfig": {

‎packages/db-ui-elements-stencil/src/components/db-brand/db-brand.tsx

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -44,12 +44,12 @@ export class DbBrand {
4444
rel={this.anchorRelation}
4545
>
4646
<img src={this.src} alt={this.alt} class="elm-image is-logo" />
47-
{this.siteNameLink && (
48-
<span class="is-site-name">
49-
<slot />
50-
</span>
51-
)}
5247
</a>
48+
{this.siteNameLink && (
49+
<span class="is-site-name">
50+
<slot />
51+
</span>
52+
)}
5353
{!this.siteNameLink && (
5454
<span class="is-site-name">
5555
<slot />

‎packages/db-ui-elements-stencil/src/components/db-breadcrumb/stories/db-breadcrumb.stories.mdx

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -47,9 +47,7 @@ There are 3 options to use &lt;db-breadcrumb&gt;:
4747
<db-breadcrumb aria-label="Breadcrumb">
4848
<db-link href="#">Startseite</db-link>
4949
<db-link href="#">Page XYZ</db-link>
50-
<db-link href="#" current="location">
51-
Page ZYS
52-
</db-link>
50+
<db-link href="#" current="location">Page ZYS</db-link>
5351
</db-breadcrumb>
5452
</Canvas>
5553

‎packages/db-ui-elements-stencil/src/components/db-chip/db-chip.tsx

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
// eslint-disable-next-line @typescript-eslint/no-unused-vars
12
import { Component, Host, h, Prop } from '@stencil/core';
23
import { uuid } from '../../utils/utils';
34

@@ -75,12 +76,7 @@ export class DbChip {
7576
name={this.name}
7677
checked={this.selected}
7778
/>
78-
<label
79-
htmlFor={this.input_id}
80-
role="button"
81-
aria-hidden="true"
82-
data-variant={this.variant}
83-
>
79+
<label htmlFor={this.input_id} data-variant={this.variant}>
8480
{this.icon ? <db-icon variant="20-outline" icon={this.icon} /> : null}
8581
<slot />
8682
{this.iconafter ? (

‎packages/db-ui-elements-stencil/src/components/db-header/stories/db-header.intro.stories.mdx

Lines changed: 4 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -20,12 +20,8 @@ A header component.
2020
<db-header>
2121
<db-brand>DB-UI Elements</db-brand>
2222
<db-mainnavigation>
23-
<db-link href="#" rel="index" current="page">
24-
Startseite
25-
</db-link>
26-
<db-link href="#" rel="offers">
27-
Aufträge
28-
</db-link>
23+
<db-link href="#" rel="index" current="page">Startseite</db-link>
24+
<db-link href="#" rel="offers">Aufträge</db-link>
2925
</db-mainnavigation>
3026
</db-header>
3127
</Canvas>
@@ -37,12 +33,8 @@ A header component.
3733
<db-brand>DB-UI Elements</db-brand>
3834
<db-meta>
3935
<db-metanavigation>
40-
<db-link icon="settings" href="#">
41-
Einstellungen
42-
</db-link>
43-
<db-link icon="chat" icononly href="#">
44-
Nachrichten
45-
</db-link>
36+
<db-link icon="settings" href="#">Einstellungen</db-link>
37+
<db-link icon="chat" icononly href="#">Nachrichten</db-link>
4638
</db-metanavigation>
4739
</db-meta>
4840
</db-header>

‎packages/db-ui-elements-stencil/src/components/db-language-switcher/stories/db-language-switcher.intro.stories.mdx

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -41,12 +41,8 @@ There are three options to use &lt;db-language-switcher&gt;:
4141

4242
<Canvas>
4343
<db-language-switcher aria-selected-index="1">
44-
<db-link title="English language" href="#">
45-
EN
46-
</db-link>
47-
<db-link title="Deutsche Sprache" href="#">
48-
DE
49-
</db-link>
44+
<db-link title="English language" href="#">EN</db-link>
45+
<db-link title="Deutsche Sprache" href="#">DE</db-link>
5046
</db-language-switcher>
5147
</Canvas>
5248

0 commit comments

Comments
 (0)