From 89ff464f19b67cbcd56c79eea624a4f7e072f310 Mon Sep 17 00:00:00 2001 From: Maximilian Franzke <787658+mfranzke@users.noreply.github.com> Date: Tue, 15 Nov 2022 11:44:11 +0100 Subject: [PATCH 1/6] Update icons.scss --- source/_patterns/00-base/icons/icons.scss | 37 ++--------------------- 1 file changed, 2 insertions(+), 35 deletions(-) diff --git a/source/_patterns/00-base/icons/icons.scss b/source/_patterns/00-base/icons/icons.scss index 4311ea8bac..514f92eeb2 100644 --- a/source/_patterns/00-base/icons/icons.scss +++ b/source/_patterns/00-base/icons/icons.scss @@ -1,35 +1,2 @@ -// @import "icons.variables"; - -@import "icons.variables"; -@import "icons.attributes-mappings"; -@import "icons.helpers"; -@import "icons.custom-properties"; -@import "icons.font-faces"; -@import "icons.placeholder"; - -[data-icon], -[data-icon-before] { - &::before { - @extend %icon; - margin-inline-end: var(--icon-margin-after, #{$icon-content-space}); - } -} - -[data-icon-after] { - &::after { - @extend %icon; - margin-inline-start: var(--icon-margin-before, #{$icon-content-space}); - } -} - -// Providing a mechanism for text replacements -.is-icon-text-replace { - &[data-icon], - &[data-icon-before] { - @include is-icon-text-replace(); - } - - &[data-icon-after] { - @include is-icon-text-replace("after"); - } -} +// This file is deprecated, it will get removed with a new release; its content has been moved to DB UI Base +@import "@db-ui/base/build/scss/icon/icons.scss"; From c4e93f6291ecfc26cc3fb0b9ae4a777bc3cc353c Mon Sep 17 00:00:00 2001 From: Maximilian Franzke Date: Wed, 16 Nov 2022 08:43:08 +0100 Subject: [PATCH 2/6] fix: stylelint feedback --- source/_patterns/00-base/icons/icons.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/source/_patterns/00-base/icons/icons.scss b/source/_patterns/00-base/icons/icons.scss index 514f92eeb2..05c3c59a5d 100644 --- a/source/_patterns/00-base/icons/icons.scss +++ b/source/_patterns/00-base/icons/icons.scss @@ -1,2 +1,2 @@ // This file is deprecated, it will get removed with a new release; its content has been moved to DB UI Base -@import "@db-ui/base/build/scss/icon/icons.scss"; +@import "@db-ui/base/build/scss/icon/icons"; From 9e6cdddaf6be2ed4b44704f35bbfe94e043ca2d5 Mon Sep 17 00:00:00 2001 From: Maximilian Franzke <787658+mfranzke@users.noreply.github.com> Date: Mon, 21 Nov 2022 11:28:19 +0100 Subject: [PATCH 3/6] Delete _rollup.assets-paths.scss --- source/css/_rollup.assets-paths.scss | 4 ---- 1 file changed, 4 deletions(-) delete mode 100644 source/css/_rollup.assets-paths.scss diff --git a/source/css/_rollup.assets-paths.scss b/source/css/_rollup.assets-paths.scss deleted file mode 100644 index ea144bb651..0000000000 --- a/source/css/_rollup.assets-paths.scss +++ /dev/null @@ -1,4 +0,0 @@ -// If this library is used as an npm dependency, and the source files should be included rather than css, this corrects the paths. -$icons-path: "@db-ui/core/dist/icons/"; -$images-path: "@db-ui/core/dist/images/"; -$fonts-path: "@db-ui/core/dist/fonts/"; From 78e16b3e0ada91293787bb1e6e5aa8ec51d107f8 Mon Sep 17 00:00:00 2001 From: Maximilian Franzke <787658+mfranzke@users.noreply.github.com> Date: Mon, 21 Nov 2022 11:28:37 +0100 Subject: [PATCH 4/6] Delete _webpack.assets-paths.scss --- source/css/_webpack.assets-paths.scss | 4 ---- 1 file changed, 4 deletions(-) delete mode 100644 source/css/_webpack.assets-paths.scss diff --git a/source/css/_webpack.assets-paths.scss b/source/css/_webpack.assets-paths.scss deleted file mode 100644 index 02e7de82f5..0000000000 --- a/source/css/_webpack.assets-paths.scss +++ /dev/null @@ -1,4 +0,0 @@ -// If this library is used as an npm dependency, and the source files should be included rather than css, this corrects the paths. -$icons-path: "~@db-ui/core/dist/icons/"; -$images-path: "~@db-ui/core/dist/images/"; -$fonts-path: "~@db-ui/core/dist/fonts/"; From 14939afa80057c0cd8091d9a437a0596c1efa5fa Mon Sep 17 00:00:00 2001 From: Maximilian Franzke <787658+mfranzke@users.noreply.github.com> Date: Mon, 21 Nov 2022 11:33:14 +0100 Subject: [PATCH 5/6] Update migrationGuide.adoc --- docs/migrationGuide.adoc | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/docs/migrationGuide.adoc b/docs/migrationGuide.adoc index 0098088373..b0701ae71a 100644 --- a/docs/migrationGuide.adoc +++ b/docs/migrationGuide.adoc @@ -15,6 +15,11 @@ We've removed the following files, that we already deprecated within the previou - `@db-ui/core/sources/css/enterprise/db-ui-core-rollup.scss` - `@db-ui/core/sources/css/enterprise/db-ui-core-webpack.scss` +=== Moved "base" files DB UI Core to DB UI Base + +The following files including basic styles have been moved from DB UI Core to DB UI Base: +- source/_patterns/00-base/icons/icons.scss -> @db-ui/base/build/scss/icon/icons.scss + === progress We've remove the deprecated previous HTML implementation of the label by an `output` element and replaced it by an actual `label` element. Necessary changes: From bc4a7dd9e58a056da36572b3578e2bc0b0241fa6 Mon Sep 17 00:00:00 2001 From: Maximilian Franzke <787658+mfranzke@users.noreply.github.com> Date: Mon, 21 Nov 2022 11:34:11 +0100 Subject: [PATCH 6/6] Update migrationGuide.adoc --- docs/migrationGuide.adoc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/docs/migrationGuide.adoc b/docs/migrationGuide.adoc index b0701ae71a..8b2d2e594a 100644 --- a/docs/migrationGuide.adoc +++ b/docs/migrationGuide.adoc @@ -19,6 +19,8 @@ We've removed the following files, that we already deprecated within the previou The following files including basic styles have been moved from DB UI Core to DB UI Base: - source/_patterns/00-base/icons/icons.scss -> @db-ui/base/build/scss/icon/icons.scss +- source/css/_rollup.assets-paths.scss -> @db-ui/base/build/scss/_rollup.assets-paths.scss +- source/css/_webpack.assets-paths.scss -> @db-ui/base/build/scss/_webpack.assets-paths.scss === progress