migrated to pnpm, next-js example, fixed warning #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
example
|
Right now the only thing that doesn't work is Gatsby but I'm okay with it for the time being. |
This was referenced Mar 5, 2023
|
getting some errors trying to run commands on this branch
|
|
Glad to see this merged. Will there be a new release soon @dayhaysoos ? |
|
Hey @alec-bfa, I did the new release right after this merge! |
|
Oh I missed it since I saw the latest release in github was from 2021. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This is a PR that addresses quite a few things:
There's definitely still some work to do.
rollup -c -wcommand doesn't work as well anymore. This allowed me to make updates to the library and see the changes get reflected. Right now, I have to manually update the bundle myself withrollup -cand switch back and switch back to run the server again. Not sure how to fix this but I'll look into it.I finally addressed the warning that always got thrown in Next.js. Don't really need a review here because it was a one-liner that I sat on for about 2 years
Added a nextjs example to the examples folder, shout outs to @lmac-1 for her amazing starter repo. I pretty much dropped it in there.
Concerns
Ripping out yarn and migrating to pnpm is kinda scary. I still have a lot of errors/warnings being thrown by pnpm. So far, things are working better than they did before so that's a great sign, but not sure if this is safe enough to merge into master (I need to change to main soon).
Any insight would be appreciated.