Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance timing panel to give more granular results #136

Open
2 of 3 tasks
danielcompton opened this issue Jan 29, 2018 · 0 comments
Open
2 of 3 tasks

Enhance timing panel to give more granular results #136

danielcompton opened this issue Jan 29, 2018 · 0 comments

Comments

@danielcompton
Copy link
Contributor

danielcompton commented Jan 29, 2018

Correct timing skew from subscriptions running while views render

  • re-frame's traces measure elapsed time between the start and end of the tracing period. This measures the total elapsed time. If a subscription runs while a view is rendering, the time the subscription took to run is measured in the subscription's trace, as well as the parent view.

In the traces and timing panels we need to calculate the 'self' time for each trace and use that when calculating the time taken to run views and subscriptions.

More granular results

  • Once we do this we can separate out the timing for each animation frame into view, subscription, and React etc.

Collect event and effect timing

  • We don't have granular enough traces around handling an event, we need to add more tracing here.
@danielcompton danielcompton added this to the 0.2.0 milestone Feb 9, 2018
@danielcompton danielcompton changed the title Correct timing skew from subscriptions running while views render Enhance timing panel to give more granular results Feb 10, 2018
danielcompton added a commit that referenced this issue Feb 10, 2018
danielcompton added a commit that referenced this issue Feb 13, 2018
@danielcompton danielcompton reopened this Feb 13, 2018
@superstructor superstructor removed this from the 0.2.0 milestone Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants