✨ Add etherscan api #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dawsbot
requested changes
May 29, 2024
|
|
||
| public convertToTokenRows(data: ApiResponse): TokenRows { | ||
| const tokens = data.d.data.map((obj) => ({ | ||
| tokenName: obj.tokenName, |
There was a problem hiding this comment.
it might be cleaner to do this like:
const tokens = data.d.data.map(obj => ({
...obj,
address: obj.contractAddress
});| import { firefox } from "playwright"; | ||
|
|
||
| export async function openBrowser(): Promise<{ browser: Browser; page: Page }> { | ||
| const browser = await firefox.launch({ headless: false }); |
There was a problem hiding this comment.
Don't we already have an area in the codebase with browser automation like this? It could be good to de-duplicate so we only depend on playwright in one place.
| @@ -38,6 +44,22 @@ export class EtherscanHtmlParser extends HtmlParser { | |||
| return addressesInfo; | |||
| } | |||
|
|
|||
| public async login(page: Page, baseUrl: string) { | |||
There was a problem hiding this comment.
We never needed this login before, how come it's needed now?
I thought the parent class did the login
scripts/HtmlParser/HtmlParser.ts
Outdated
| import type { AccountRows, TokenRows } from "../AnyscanPuller"; | ||
| import { ApiParser } from "../ApiParser"; | ||
|
|
||
| async function sleep(ms: number): Promise<void> { |
There was a problem hiding this comment.
Didn't we already have a sleep function elsewhere in the codebase? Let's de-duplicate if so
9 tasks
dawsbot
requested changes
May 29, 2024
scripts/ApiParser.test.ts
Outdated
| address: "0x9ff58f4ffb29fa2266ab25e75e2a8b3503311656", | ||
| }); | ||
| await closeBrowser(browser); | ||
| }, 1000000); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #66
@dawsbot please review this commit. this is a hacky solution that works but I think there is some duplicate code to clean up.