Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull expanded token names #36

Closed
dawsbot opened this issue Mar 26, 2024 · 3 comments
Closed

Pull expanded token names #36

dawsbot opened this issue Mar 26, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@dawsbot
Copy link
Owner

dawsbot commented Mar 26, 2024

When a token name is beyond _ characters, it's currently truncated with "..." in the codebase:

https://github.com/dawsbot/evm-labels/blob/367e5f73f52b5f428872131eea99db1abfcb1010/data/etherscan/0x-protocol-ecosystem/tokens.json#L4

The confusing thing is that this expanded name exists nowhere in the DOM. Instead, this expanded name exists within a separate POST request response:

curl 'https://etherscan.io/tokens.aspx/GetTokensBySubLabel'...

The full CURL is not in this issue because it contains my cookie. This POST should only be done for tokens.json files which contain a "...". Most do not need this.

@dawsbot dawsbot added enhancement New feature or request low priority not very urgent labels Mar 26, 2024
@dawsbot
Copy link
Owner Author

dawsbot commented May 18, 2024

@dawsbot dawsbot removed the low priority not very urgent label May 18, 2024
@kylewandishin
Copy link
Collaborator

bscscan uses a similar design to polygon and ftm so we should make a new pr to incorporate the API pulling method and testing.

@kylewandishin
Copy link
Collaborator

@dawsbot I think we should close this issue as it is now being tracked by issue #73

@dawsbot dawsbot closed this as completed Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

2 participants