-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pull expanded token names #36
Labels
enhancement
New feature or request
Comments
BSCScan suffers from this issue as-well: |
bscscan uses a similar design to polygon and ftm so we should make a new pr to incorporate the API pulling method and testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When a token name is beyond _ characters, it's currently truncated with "
...
" in the codebase:https://github.com/dawsbot/evm-labels/blob/367e5f73f52b5f428872131eea99db1abfcb1010/data/etherscan/0x-protocol-ecosystem/tokens.json#L4
The confusing thing is that this expanded name exists nowhere in the DOM. Instead, this expanded name exists within a separate POST request response:
curl 'https://etherscan.io/tokens.aspx/GetTokensBySubLabel'...
The full CURL is not in this issue because it contains my cookie. This POST should only be done for
tokens.json
files which contain a "...
". Most do not need this.The text was updated successfully, but these errors were encountered: