-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
generate snippets for subclasses #61
Conversation
@salkin-mada Thanks for this! I will look over it during the weekend. |
@salkin-mada Hi again, sorry for the late response. I tried out the PR, and it's definitely nice to have more snippets for subclasses! We do get some additional snippets though that produces some noise (imho), for instance we get Just to be clear, this was also the case before this PR, only now we get even more :) I'm starting to think that we might need a more granular approach to creating snippets? Maybe by ignoring some methods such as |
@davidgranstrom Indeed there is a lot of additional noise, which is really not ideal. |
also see #63, a new parser for the classes and methods with more flexibility would be a thing to consider |
@salkin-mada Yes, I agree. I think a good start would be to study https://github.com/supercollider/supercollider/blob/develop/SCClassLibrary/scide_scqt/ScIDE.sc in detail and see what/if we could reuse any of the methods. I'm currently working on better function signature hints ("argument hints") and I think I will need something more robust for that as well than what we have now. |
Closing this for now since it probably will be resolved by using better introspection from https://github.com/davidgranstrom/scnvim/tree/topic/arghints-lua The plan is to generate snippets etc. directly from lua based on the introspection data generated by sclang. |
"SomeSubClass".class.methods
returnsnil
, class methods comes from the superclass.I have therefore created an additional
do
func adding snippets for the subclass containing the methods from the superclass... one small "post_everything" commit sneaked it's way into this PR. sorry :)
closes #60