Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

require('astravel') broken due to @babel/runtime dependency #34

Open
mureinik opened this issue Nov 8, 2022 · 0 comments · May be fixed by #35 or #40
Open

require('astravel') broken due to @babel/runtime dependency #34

mureinik opened this issue Nov 8, 2022 · 0 comments · May be fixed by #35 or #40

Comments

@mureinik
Copy link

mureinik commented Nov 8, 2022

[email protected] added a dependency on @babel/runtime but didn't declare it as a dependency in package.json, only as a devDependency. As a result, astravel cannot be used with a require statement (at least not out of the box. It will of course work if you manually install the dependency). Minimal reproducer:

mureinik@computer:~/src/git$ mkdir astravel-require

mureinik@computer:~/src/git$ cd astravel-require/

mureinik@computer:~/src/git/astravel-require$ npm init -y
Wrote to /home/mureinik/src/git/astravel-require/package.json:

{
  "name": "astravel-require",
  "version": "1.0.0",
  "description": "",
  "main": "index.js",
  "scripts": {
    "test": "echo \"Error: no test specified\" && exit 1"
  },
  "keywords": [],
  "author": "",
  "license": "ISC"
}



mureinik@computer:~/src/git/astravel-require$ npm install astravel

added 1 package, and audited 2 packages in 484ms

found 0 vulnerabilities
npm notice
npm notice New patch version of npm available! 8.19.2 -> 8.19.3
npm notice Changelog: https://github.com/npm/cli/releases/tag/v8.19.3
npm notice Run npm install -g [email protected] to update!
npm notice

mureinik@computer:~/src/git/astravel-require$ node -e "require('astravel')"
node:internal/modules/cjs/loader:988
  throw err;
  ^

Error: Cannot find module '@babel/runtime/helpers/interopRequireDefault'
Require stack:
- /home/mureinik/src/git/astravel-require/node_modules/astravel/dist/require/defaultTraveler.js
- /home/mureinik/src/git/astravel-require/node_modules/astravel/dist/require/astravel.js
- /home/mureinik/src/git/astravel-require/[eval]
    at Function.Module._resolveFilename (node:internal/modules/cjs/loader:985:15)
    at Function.Module._load (node:internal/modules/cjs/loader:833:27)
    at Module.require (node:internal/modules/cjs/loader:1057:19)
    at require (node:internal/modules/cjs/helpers:103:18)
    at Object.<anonymous> (/home/mureinik/src/git/astravel-require/node_modules/astravel/dist/require/defaultTraveler.js:3:30)
    at Module._compile (node:internal/modules/cjs/loader:1155:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1209:10)
    at Module.load (node:internal/modules/cjs/loader:1033:32)
    at Function.Module._load (node:internal/modules/cjs/loader:868:12)
    at Module.require (node:internal/modules/cjs/loader:1057:19) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '/home/mureinik/src/git/astravel-require/node_modules/astravel/dist/require/defaultTraveler.js',
    '/home/mureinik/src/git/astravel-require/node_modules/astravel/dist/require/astravel.js',
    '/home/mureinik/src/git/astravel-require/[eval]'
  ]
}
mureinik added a commit to mureinik/astravel that referenced this issue Nov 8, 2022
@mureinik mureinik linked a pull request Nov 8, 2022 that will close this issue
@morganney morganney linked a pull request Jun 28, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant