Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

midi->note (convert MIDI note number to e.g. :C#4) #8

Open
daveyarwood opened this issue Jan 11, 2016 · 0 comments
Open

midi->note (convert MIDI note number to e.g. :C#4) #8

daveyarwood opened this issue Jan 11, 2016 · 0 comments

Comments

@daveyarwood
Copy link
Owner

We can do this now that we have the ability to set a key.

This will require that both *tonic* and *scale-type* are not nil, so that there can be a correct enharmonic spelling based on the key.

For example, (midi->note 68) should return :G#4 if the key is E major, and :Ab4 if the key is Ab major.

We can just support major/minor at first, worry about more advanced scales later. (see #7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@daveyarwood