Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include fs2.io.file.Path into the library #87

Open
Hombre-x opened this issue Aug 18, 2024 · 1 comment
Open

Include fs2.io.file.Path into the library #87

Hombre-x opened this issue Aug 18, 2024 · 1 comment

Comments

@Hombre-x
Copy link
Contributor

Hombre-x commented Aug 18, 2024

We should re import this type into shellfish as it is an essential dependency on the whole library. I don't know the best way to achieve that but it would be nice to do something like this:

package shellfish.domain

import fs2.io.file.Path as Fs2Path

type Path = Fs2Path

And in the import package:

package shellfish

export shellfish.domain.Path

export shellfish.FilesOs

export shellfish.syntax.path.*

So doing import shellfish.* would import everything including the Path type.

@TonioGela
Copy link
Contributor

I'm not 100% sure that's a good idea. Magically importing too stuff would hide too much complexity to the users IMHO. Also the import of fs2.io.file.Path is the very same the users will have to do when using fs2-io directly, so there's an added value in forcing them to use it.

For what concerns the uni-import, once decided the name we'll restructure the lib and possibly put everything in the <lib-name> package, so that we can import it with import <lib-name>.*

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants