Properly escape selected facets in search.html #643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hancush
approved these changes
Aug 20, 2020
|
Rebuilt and replicated testing! This is good to go. I'll go ahead and merge / deploy. Thank you again, @jeancochrane. ❤ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR updates
search/search.htmlto retrieve selected facets from a<script>element produced byjson_script.Checklist
Notes
I've pinned
django-councilmaticto my feature branch for the purposes of testing datamade/django-councilmatic#271. Before pulling this in, I'll adjustrequirements.txtto reset the version ofdjango-councilmaticto the version we deploy to fix datamade/django-councilmatic#270.Testing Instructions
docker-compose up --build appConnects datamade/django-councilmatic#270.