Skip to content

Commit 4e8eba8

Browse files
authored
feat: add logging durations for screenshot async service (apache#30884)
1 parent ac3a10d commit 4e8eba8

File tree

1 file changed

+11
-3
lines changed

1 file changed

+11
-3
lines changed

superset/utils/screenshots.py

+11-3
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424

2525
from superset import feature_flag_manager
2626
from superset.dashboards.permalink.types import DashboardPermalinkState
27+
from superset.extensions import event_logger
2728
from superset.utils.hashing import md5_sha_from_dict
2829
from superset.utils.urls import modify_url_query
2930
from superset.utils.webdriver import (
@@ -91,7 +92,8 @@ def get_screenshot(
9192
self, user: User, window_size: WindowSize | None = None
9293
) -> bytes | None:
9394
driver = self.driver(window_size)
94-
self.screenshot = driver.get_screenshot(self.url, self.element, user)
95+
with event_logger.log_context("screenshot", screenshot_url=self.url):
96+
self.screenshot = driver.get_screenshot(self.url, self.element, user)
9597
return self.screenshot
9698

9799
def get(
@@ -169,7 +171,10 @@ def compute_and_cache( # pylint: disable=too-many-arguments
169171

170172
# Assuming all sorts of things can go wrong with Selenium
171173
try:
172-
payload = self.get_screenshot(user=user, window_size=window_size)
174+
with event_logger.log_context(
175+
f"screenshot.compute.{self.thumbnail_type}", force=force
176+
):
177+
payload = self.get_screenshot(user=user, window_size=window_size)
173178
except Exception as ex: # pylint: disable=broad-except
174179
logger.warning("Failed at generating thumbnail %s", ex, exc_info=True)
175180

@@ -182,7 +187,10 @@ def compute_and_cache( # pylint: disable=too-many-arguments
182187

183188
if payload:
184189
logger.info("Caching thumbnail: %s", cache_key)
185-
cache.set(cache_key, payload)
190+
with event_logger.log_context(
191+
f"screenshot.cache.{self.thumbnail_type}", force=force
192+
):
193+
cache.set(cache_key, payload)
186194
logger.info("Done caching thumbnail")
187195
return payload
188196

0 commit comments

Comments
 (0)