Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Django Requirements #77

Closed
matclayton opened this issue Oct 12, 2021 · 5 comments · May be fixed by #81
Closed

Django Requirements #77

matclayton opened this issue Oct 12, 2021 · 5 comments · May be fixed by #81

Comments

@matclayton
Copy link

Channels 3.x works with Django 2.2+ as seen here (https://github.com/django/channels/blob/main/setup.py#L16)

However DjangoChannelsGraphqlWs requires Django >3, it would be better to align these to Django >2.2 and allow maximal flexibility.

For example we are upgrading on Django 2.2 from Channels 1->3, which should be doable, except for the requirements in DjangoChannelsGraphqlWs (https://github.com/datadvance/DjangoChannelsGraphqlWs/blob/master/pyproject.toml#L56), which I dont believe is a necessary restriction, as I can't see anything in this repro whic would need Django 3.x
@Luferov
Copy link

Luferov commented Dec 7, 2021

Also, Django 4.0 is released!

tony added a commit to tony/DjangoChannelsGraphqlWs that referenced this issue Jan 5, 2022
@tony
pyproject.toml: Loosen django restraint to 2.2
285f893 
Fixes datadvance#77
@tony tony mentioned this issue Jan 5, 2022
Open
@tony
Copy link

tony commented Jan 5, 2022 •
edited

#77 will do it.

Will make another PR for django 4.0, issue at #82

tony added a commit to tony/DjangoChannelsGraphqlWs that referenced this issue Feb 1, 2022
@tony
pyproject.toml: Loosen django restraint to 2.2
6b57c23 
Fixes datadvance#77
@Luferov
Copy link

Luferov commented Feb 6, 2022

It will be good!

@tony
Copy link

tony commented Feb 6, 2022

@Luferov

PRs:

@prokher
Copy link
Member

prokher commented Apr 27, 2023

A new version 1.0.0rc is available on PyPI. It supports both the latest Django and the latest Graphene. Closing this. Feel free to reopen or file a new issue in case of problems.

@prokher prokher closed this as completed Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

django: Loosen version constraint for django 2.2 users tony/DjangoChannelsGraphqlWs
4 participants
@tony @matclayton @prokher @Luferov