Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing "scale" argument in plotting RBG with image stretch #305

Open
sjgraves opened this issue Dec 16, 2019 · 1 comment
Open

removing "scale" argument in plotting RBG with image stretch #305

sjgraves opened this issue Dec 16, 2019 · 1 comment

Comments

@sjgraves
Copy link

Episode 5 (working with multi-band rasters) introduces the concept of image stretching when plotting a full color RGB. After the explanation of image stretching, the plotRGB function is used again, with the added arguments of stretch and scale. For example:

plotRGB(RGB_stack_HARV,
r = 1, g = 2, b = 3,
scale = 800,
stretch = "lin")

It's not apparent that the scale argument is necessary - removing it or changing the value produces the same result. In addition, the value of 800 doesn't make sense, since this argument defines the max value of the 3 channels (which is 255) and defaults to either 255 or the maximum value.

Without an explanation of the scale argument and why it's needed, it seems like it can be removed to keep the function simple.

@jsta
Copy link
Member

jsta commented Dec 18, 2019

Sounds good to me. Could you open a pull request for this change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants