Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential performance issue: concat slow in pandas below 2.1 version #389

Open
TendouArisu opened this issue Mar 1, 2024 · 2 comments
Open
Labels
enhancement New feature or request future This issue is in a backlog of ideas to possibly be done in the future question Further information is requested

Comments

@TendouArisu
Copy link

Issue Description:

Hello.
I have discovered a performance degradation in the .concat function of pandas version 1.5.2. And I notice the repository depends on pandas 1.5.2 in python/requirements.txt. I am not sure whether this performance problem in pandas will affect this repository. I found some discussions on pandas GitHub related to this issue, including #50652 and #52685.
I also found that python/tempo/intervals.py and python/tempo/tsdf.py used the influenced api. There may be more files using the influenced api.

Suggestion

I would recommend considering an upgrade to a different version of pandas >= 2.1 or exploring other solutions to optimize the performance of .concat.
Any other workarounds or solutions would be greatly appreciated.
Thank you!

@R7L208 R7L208 added enhancement New feature or request question Further information is requested future This issue is in a backlog of ideas to possibly be done in the future labels Mar 1, 2024
@R7L208
Copy link
Contributor

R7L208 commented Mar 1, 2024

Thanks @TendouArisu for raising this issue. We try to map our dependencies to those of Databricks Runtimes so we're not able to update pandas everywhere within the project.

Have you encountered any performance issues when using the methods in tsdf and intervals that call .concat?

@TendouArisu
Copy link
Author

I haven't encountered obvious perf problems up to now. My issue is a potential perf problem and I think it probably influences the perf. I raise it because I encountered similar problems in other repositories related to pandas concat. If it is hard to update the dependencies, I think it won't cause a significant impact.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request future This issue is in a backlog of ideas to possibly be done in the future question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants