-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Matching the response tokens #197
Comments
CC @matthayes , WDYT? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hello, thanks for the nice reference code! I noticed the following code tries to match the response tokens, but it might match the instruction tokens instead
dolly/training/trainer.py
Lines 60 to 63 in aaa0ecb
This is because it breaks when the first token matches, but
'### Response:\n'
is encoded with[21017, 18261, 25, 198]
., but it matches### Instruction:\n
([21017, 46486, 25, 198]
) instead.To resolve the issue and if it is indeed that you intended to match the response tokens, you should consider the following snippet instead :)
Our related issue huggingface/trl#445 (comment)
The text was updated successfully, but these errors were encountered: