Fix Permitted Value for Expression Type Rules #36
Conversation
There was a problem hiding this comment.
@goodwillpunning Do we have any tests on the output reports? I didn't see any changes to tests that change the actual/permitted values. Did I just miss them?
| @@ -48,7 +48,7 @@ class Validator(ruleSet: RuleSet, detailLvl: Int) extends SparkSessionWrapper { | |||
| struct( | |||
| lit(rule.ruleName).alias("ruleName"), | |||
| (rule.inputColumn === rule.validExpr).alias("passed"), | |||
| lit(rule.inputColumnName).alias("permitted"), | |||
| rule.inputColumn.cast("string").alias("permitted"), | |||
There was a problem hiding this comment.
Here I was expecting there to be the following columns.
ruleName - good
passed - good
logic - not present. This should be the SQL expr used to derive the "permitted"
permitted - allowed value or range
actual - the result of the expression value
|
|
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #36 +/- ##
==========================================
+ Coverage 87.50% 89.63% +2.13%
==========================================
Files 5 5
Lines 168 164 -4
Branches 3 4 +1
==========================================
Hits 147 147
+ Misses 21 17 -4 ☔ View full report in Codecov by Sentry. |
This commit corrects a display-only bug in the validation results when expression type Rules are used. Previously, the
permittedcolumn would display the Rule expression as a String. This commit updates thepermittedcolumn to the evaluated expression.This commit also removes an unused object,
Lookups.