Skip to content

Commit 6bf55e1

Browse files
committed
chore: fix unit test
Signed-off-by: Kould <kould2333@gmail.com>
1 parent 56c877b commit 6bf55e1

5 files changed

Lines changed: 7 additions & 4 deletions

File tree

src/query/service/tests/it/pipelines/filter/random_filter_expr.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -147,6 +147,7 @@ fn convert_predicate_tree_to_scalar_expr(node: PredicateNode, data_type: &DataTy
147147
table_name: None,
148148
column_position: None,
149149
table_index: None,
150+
source_table_index: None,
150151
column_name: "".to_string(),
151152
index: 0,
152153
data_type: Box::new(data_type.clone()),

src/query/sql/src/planner/optimizer/rule/rewrite/rule_subquery_not_in_to_in.rs

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -85,13 +85,14 @@ impl Rule for RuleSubqueryNotInToIn {
8585
) -> databend_common_exception::Result<()> {
8686
let filter: Filter = s_expr.plan().clone().try_into()?;
8787
let mut join: Join = s_expr.children[0].plan().clone().try_into()?;
88-
8988
let (ScalarExpr::FunctionCall(call), Some(mark_index)) =
9089
(&filter.predicates[0], join.marker_index)
9190
else {
9291
return Ok(());
9392
};
94-
if call.func_name != "not"
93+
// subquery only one eq condition(subquery child_expr = subquery output column)
94+
if join.equi_conditions.len() != 1
95+
|| call.func_name != "not"
9596
|| call.arguments.len() != 1
9697
|| call.arguments[0]
9798
.used_columns()
@@ -100,8 +101,6 @@ impl Rule for RuleSubqueryNotInToIn {
100101
{
101102
return Ok(());
102103
}
103-
// subquery only one eq condition(subquery child_expr = subquery output column)
104-
debug_assert!(join.equi_conditions.len() == 1);
105104

106105
let condition = &join.equi_conditions[0];
107106
let ScalarExpr::BoundColumnRef(BoundColumnRef { column, .. }) = &condition.left else {

src/query/sql/tests/optimizer/filter/deduplicate_join_condition_test.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@ fn create_column_ref1(
5050
table_index,
5151
visibility: Visibility::Visible,
5252
virtual_expr: None,
53+
source_table_index: None,
5354
};
5455
ScalarExpr::BoundColumnRef(BoundColumnRef { column, span: None })
5556
}

src/query/sql/tests/optimizer/filter/infer_filter_test.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@ fn create_column_ref(index: IndexType, name: &str, data_type: DataType) -> Scala
4242
table_index: None,
4343
visibility: Visibility::Visible,
4444
virtual_expr: None,
45+
source_table_index: None,
4546
};
4647
ScalarExpr::BoundColumnRef(BoundColumnRef { column, span: None })
4748
}

src/query/sql/tests/optimizer/filter/normalize_disjunctive_filter_test.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,7 @@ fn create_bound_column_ref(
7676
table_index,
7777
visibility: Visibility::Visible,
7878
virtual_expr: None,
79+
source_table_index: None,
7980
};
8081
ScalarExpr::BoundColumnRef(BoundColumnRef { column, span: None })
8182
}

0 commit comments

Comments
 (0)