Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-merge-output-format and -f question #177

Open
astering opened this issue Dec 3, 2023 · 2 comments
Open

-merge-output-format and -f question #177

astering opened this issue Dec 3, 2023 · 2 comments
Assignees

Comments

@astering
Copy link

astering commented Dec 3, 2023

Hello, I find some weird bugs, if I let the preset "format" empty, the content of "container" will be set as argument of "-f".

For example, format = best, container = mkv, the it will be: -f best -merge-output-format mkv,

but if format is empty, container = mkv, then the argument is -f mkv.

I want to have mkv as output,merge some subtitles, but the stream maybe vp9 or h264, some videos don't have mkv, and will cause unexpected behavior.

@database64128
Copy link
Owner

When I first wrote this, I made the assumption based on my understanding of the documentation that specifying --merge-output-format alone was equivalent to specifying --format with the same argument. Looks like I was wrong.

Fixing this would require a breaking change to the preset mechanism, which might break some existing user-defined presets. But it's probably the right thing to do. For now, you can leave both format and container empty, and specify --merge-output-format, mkv as extra arguments.

@database64128 database64128 self-assigned this Dec 4, 2023
@astering
Copy link
Author

astering commented Dec 4, 2023

For now, you can leave both format and container empty, and specify --merge-output-format, mkv as extra arguments.

Yeh, that's what I set now. Thanks to custom parameters, setting any suitable parameters is always feasible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants