Skip to content

Commit 62fd717

Browse files
authored
include database info (#523)
Signed-off-by: Avi Deitcher <avi@deitcher.net>
1 parent 6c760f7 commit 62fd717

1 file changed

Lines changed: 18 additions & 1 deletion

File tree

cmd/dump.go

Lines changed: 18 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -257,7 +257,24 @@ func dumpCmd(passedExecs execs, cmdConfig *cmdConfiguration) (*cobra.Command, er
257257
bytes := int64(0)
258258
exitCode := 0
259259
backupStatus := "ok"
260-
dumpSpan.SetAttributes(attribute.String("backup.run_id", uid.String()))
260+
attrs := []attribute.KeyValue{
261+
attribute.String("backup.run_id", uid.String()),
262+
attribute.String("db.system", "mysql"),
263+
}
264+
if cmdConfig.dbconn != nil {
265+
transport := "tcp"
266+
if strings.HasPrefix(cmdConfig.dbconn.Host, "/") {
267+
transport = "unix"
268+
}
269+
attrs = append(attrs,
270+
attribute.String("network.transport", transport),
271+
attribute.String("server.address", cmdConfig.dbconn.Host),
272+
)
273+
if transport == "tcp" && cmdConfig.dbconn.Port > 0 {
274+
attrs = append(attrs, attribute.Int("server.port", cmdConfig.dbconn.Port))
275+
}
276+
}
277+
dumpSpan.SetAttributes(attrs...)
261278
defer func() {
262279
attrs := []attribute.KeyValue{
263280
attribute.String("backup.status", backupStatus),

0 commit comments

Comments
 (0)