diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index c10b0f52..e88553fd 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -1,4 +1,4 @@ -# Copyright © 2022 Cask Data, Inc. +# Copyright © 2020 Cask Data, Inc. # Licensed under the Apache License, Version 2.0 (the "License"); you may not # use this file except in compliance with the License. You may obtain a copy of # the License at @@ -11,7 +11,7 @@ # This workflow will build a Java project with Maven # For more information see: https://help.github.com/actions/language-and-framework-guides/building-and-testing-java-with-maven -# Note: Any changes to this workflow would be used only after merging into develop. +# Note: Any changes to this workflow would be used only after merging into develop name: Build with unit tests on: @@ -30,11 +30,10 @@ jobs: steps: # Pinned 1.0.0 version - uses: haya14busa/action-workflow_run-status@967ed83efa565c257675ed70cfe5231f062ddd94 - - uses: actions/checkout@v3 with: ref: ${{ github.event.workflow_run.head_sha }} - + submodules: recursive - name: Cache uses: actions/cache@v3 with: @@ -42,18 +41,16 @@ jobs: key: ${{ runner.os }}-maven-${{ github.workflow }}-${{ hashFiles('**/pom.xml') }} restore-keys: | ${{ runner.os }}-maven-${{ github.workflow }} - - name: Build with Maven run: mvn clean test -fae -T 2 -B -V -DcloudBuild -Dmaven.wagon.http.retryHandler.count=3 -Dmaven.wagon.httpconnectionManager.ttlSeconds=25 - name: Archive build artifacts - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v2.2.2 if: always() with: name: Build debug files path: | **/target/rat.txt **/target/surefire-reports/* - - name: Surefire Report # Pinned 3.5.2 version uses: mikepenz/action-junit-report@16a9560bd02f11e7e3bf6b3e2ef6bba6c9d07c32 @@ -64,3 +61,9 @@ jobs: detailed_summary: true commit: ${{ github.event.workflow_run.head_sha }} check_name: Test Report + - name: Checkstyle report + uses: tivv/checkstyle-github-action@fcf8ffb7c6a5c110bbc5dafb84aca54caf359b80 + if: always() + with: + path: '**/checkstyle-result.xml' + commit: ${{ github.event.workflow_run.head_sha }} diff --git a/.github/workflows/trigger.yml b/.github/workflows/trigger.yml index a484b21c..e5693af0 100644 --- a/.github/workflows/trigger.yml +++ b/.github/workflows/trigger.yml @@ -1,4 +1,4 @@ -# Copyright © 2022 Cask Data, Inc. +# Copyright © 2021 Cask Data, Inc. # Licensed under the Apache License, Version 2.0 (the "License"); you may not # use this file except in compliance with the License. You may obtain a copy of # the License at @@ -21,12 +21,12 @@ on: branches: [ develop, release/** ] pull_request: branches: [ develop, release/** ] - types: [ opened, synchronize, reopened, labeled ] + types: [opened, synchronize, reopened, labeled] workflow_dispatch: jobs: trigger: - runs-on: k8s-runner-e2e + runs-on: ubuntu-latest # We allow builds: # 1) When triggered manually @@ -34,13 +34,14 @@ jobs: # 3) For PRs that are labeled as build and # - It's a code change # - A build label was just added - # A bit complex, but prevents builds when other labels are manipulated. + # A bit complex, but prevents builds when other labels are manipulated if: > github.event_name == 'workflow_dispatch' || github.event_name == 'push' || (contains(github.event.pull_request.labels.*.name, 'build') && (github.event.action != 'labeled' || github.event.label.name == 'build') ) + steps: - name: Trigger build - run: echo Maven build will be triggered now \ No newline at end of file + run: echo Maven build will be triggered now diff --git a/checkstyle.xml b/checkstyle.xml index 7db227e3..8b161228 100644 --- a/checkstyle.xml +++ b/checkstyle.xml @@ -1,6 +1,10 @@ - + + + - + Based on: + https://github.com/checkstyle/checkstyle/blob/005fba53352456515cfdcdf5dcd3dea351661f2b/src/main/resources/google_checks.xml + under https://github.com/checkstyle/checkstyle/blob/005fba53352456515cfdcdf5dcd3dea351661f2b/LICENSE.apache20 + Checkstyle configuration that checks the Google coding conventions from Google Java Style + that can be found at https://google.github.io/styleguide/javaguide.html + + Checkstyle is very configurable. Be sure to read the documentation at + http://checkstyle.org (or in your downloaded distribution). + + To completely disable a check, just comment it out or delete it from the file. + To suppress certain violations please review suppression filters. - + Authors: Max Vetrenko, Ruslan Diachenko, Roman Ivanov. + --> - + + + + + + + + + + + + + + + - + + + + + + + - @@ -55,7 +95,7 @@ page at http://checkstyle.sourceforge.net/config.html --> - @@ -67,11 +107,20 @@ page at http://checkstyle.sourceforge.net/config.html --> - - - - + + + + + + + + + + + - - - - - - - - - + + - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - + + + - - - - + + + - - - - - - - - - - - - - - - - - - - - - - + + - - - + - - - - - + + - - - - - + + + + - - - - + + + + - - - - - + + - - + + + + + + + + + + + + + + + + + - inner interface declarations that are declared as static. --> - - - - - - - - - - - + + + - - - - - + + + + - - - - - + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + - - - + - - - - + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + - - - - - - - - - - + \ No newline at end of file