Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing TypeError #11102

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fixing TypeError #11102

wants to merge 1 commit into from

Conversation

sinsniwal
Copy link

@sinsniwal sinsniwal commented May 6, 2024 •
edited

---> 64 return str(self.exception) + "\n\nTraceback\n---------\n" + self.traceback

TypeError: can only concatenate str (not "traceback") to str

@sinsniwal
Fixing TypeError
8c1775d 
---> 64     return str(self.exception) + "\n\nTraceback\n---------\n" + self.traceback

TypeError: can only concatenate str (not "traceback") to str
@GPUtester
Copy link
Collaborator

Can one of the admins verify this patch?

Admins can comment ok to test to allow this one PR to run or add to allowlist to allow all future PRs from the same author to run.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 6, 2024

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

     15 files  ±0       15 suites  ±0   3h 26m 39s ⏱️ + 2m 40s
 13 121 tests ±0   11 730 ✅ ±0     931 💤 ±0  460 ❌ ±0 
162 468 runs  ±0  141 924 ✅ +2  20 084 💤  - 2  460 ❌ ±0 

For more details on these failures, see this check.

Results for commit 8c1775d. ± Comparison against base commit bc6f42b.

phofl
phofl reviewed May 6, 2024
View reviewed changes
Copy link
Collaborator

@phofl phofl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm,

can you add a test?

@sinsniwal
Copy link
Author

lgtm,

can you add a test?

Sure, I will create it by tomorrow

@sinsniwal
Copy link
Author

lgtm,

can you add a test?

Do you know if a test is required for this change? Unable to write one.

@phofl
Copy link
Collaborator

phofl commented May 7, 2024

Doesn't the reproducer from the issue work as a test if you remove the training part?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phofl phofl phofl left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeError: can only concatenate str (not "traceback") to str
3 participants
@sinsniwal @GPUtester @phofl