Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Error with Binder link #416

Open
scharlottej13 opened this issue Mar 7, 2022 · 4 comments
Open

[DOC] Error with Binder link #416

scharlottej13 opened this issue Mar 7, 2022 · 4 comments
Labels
documentation Improvements or additions to documentation

Comments

@scharlottej13
Copy link
Contributor

Report incorrect documentation

Location of incorrect documentation
There is an error loading binder in the link provided in the Quickstart section of the readme.

Describe the problems or issues found in the documentation
The error message is Error loading dask-contrib/dask-sql-binder/main! See logs below for details. and the logs show: Could not resolve ref for gh:dask-contrib/dask-sql-binder/main. Double check your URL. GitHub recently changed default branches from "master" to "main". Did you mean the "master" branch?

Steps taken to verify documentation is incorrect
I looked in the repo for where the binder files might live, but didn't find them

@scharlottej13 scharlottej13 added the documentation Improvements or additions to documentation label Mar 7, 2022
@ayushdg
Copy link
Collaborator

ayushdg commented Mar 7, 2022

Thanks for raising the issue @scharlottej13!

Looks like the original binder repository for this repo lives here: https://github.com/nils-braun/dask-sql-binder. @charlesbluca it might make sense to create an equivalent repo in dask-contrib and build on the initial work done by Nils.

@ayushdg
Copy link
Collaborator

ayushdg commented Mar 7, 2022

Happy to take this on!

@charlesbluca
Copy link
Collaborator

charlesbluca commented Mar 8, 2022

I definitely think relocating these notebooks to a more public location where we can continue contributing to it is a great idea - wondering if maybe a better place to relocate these notebooks would be dask-examples? Looking at Dask-ML's binder link, it seems to use the binder generated there with a filepath to specify the notebook to load into.

EDIT:

Will also note that there was a WIP to get a dask-sql notebook added there dask/dask-examples#171

@ayushdg
Copy link
Collaborator

ayushdg commented Mar 9, 2022

That seems like a possible options as well. Here's what I have so far:

  1. Move notebooks to Dask-examples and add dask-sql as requirement to dask-examples.
  2. Move notebooks and environment to a new repository or dask-sql itself.
  3. Move notebooks to dask-examples but create environment elsewhere (dask-sql/new repo).

Option 1 looks like the best one so far.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants