chore: update @openally/config.eslint (#95)

Author: fabnguess

.eslintrc

@@ -0,0 +1,3 @@
+import { typescriptConfig } from "@openally/config.eslint";
+
+export default typescriptConfig();

eslint.config.mjs

@@ -10,7 +10,7 @@
     "prepublishOnly": "npm run build",
     "test": "glob -c \"tsx --test\" \"./test/**/*.spec.ts\"",
     "coverage": "c8 --all -r html npm test",
-    "lint": "eslint src/*.ts test/*.ts"
+    "lint": "eslint src test"
   },
   "repository": {
     "type": "git",
@@ -27,7 +27,7 @@
   },
   "homepage": "https://github.com/dashlog/core#readme",
   "devDependencies": {
-    "@nodesecure/eslint-config": "^1.9.0",
+    "@openally/config.eslint": "^1.3.0",
     "@types/node": "^22.0.0",
     "c8": "^10.1.2",
     "glob": "^11.0.0",

package.json

@@ -12,7 +12,7 @@ export type DashlogPlugins = keyof typeof plugins;
 export type DashlogOrganization<T extends object> = {
   logo: string;
   projects: DashlogRepository<T>[];
-}
+};
 
 export interface IFetchOrgMetadataOptions<Plugins extends DashlogPlugins> {
   plugins: Plugins[];

src/index.ts

@@ -10,10 +10,10 @@ const kScannerLock = new Mutex({ concurrency: 5 });
 
 export type NodesecurePlugin = {
   nodesecure?: scanner.tarball.ScannedPackageResult;
-}
+};
 
 export async function execute(
-  orgName: string,
+  _orgName: string,
   repository: DashlogRepository<NodesecurePlugin>
 ) {
   if (repository.package_name === null) {

src/plugins/nodesecure.ts

@@ -6,7 +6,7 @@ import { DashlogRepository } from "../services/repository.js";
 
 export type ScorecardPlugin = {
   scorecard?: scorecard.ScorecardResult | null;
-}
+};
 
 export async function execute(
   orgName: string,

src/plugins/scorecard.ts

@@ -90,11 +90,11 @@ export default class Repository {
   }
 
   async #fetchLastGithubCommit() {
-    // eslint-disable-next-line max-len
-    const uri = `${this.#repository.commits_url.slice(0, this.#repository.commits_url.length - kCommitUrlPostfixLen)}?per_page=${kMaxCommitFetch}`;
+    const url = new URL(this.#repository.commits_url.slice(0, this.#repository.commits_url.length - kCommitUrlPostfixLen));
+    url.searchParams.set("per_page", kMaxCommitFetch.toString());
 
     const { data: commits } = await httpie.get<Octokit.Endpoints["GET /repos/{owner}/{repo}/commits"]["response"]["data"]>(
-      uri, { headers: this.#org.headers }
+      url, { headers: this.#org.headers }
     );
     this.#commits = commits;
     const lastCommit = commits[0];

src/services/repository.ts

@@ -53,5 +53,3 @@ describe("execute()", async() => {
     assert.strictEqual(repo.plugins.scorecard, null);
   });
 });
-
-