[analyzer] Uniformly use dispatchCollectionElement.

Modifies the resolver so that all recursive visits of collection
elements go through `ResolverVisitor.dispatchCollectionElement`. This
prepares for a follow-up CL in which I will be adding debugging checks
to `ResolverVisitor.dispatchCollectionElement` to help ensure that the
proper offsets are propagated to the flow analysis log.

Part of #63816.

Change-Id: I6068d0dde7368ce486ba60bdeaa8fecb6a6a6964
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/532120
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>

Author: stereotype441

pkg/analyzer/lib/src/dart/resolver/for_resolver.dart

@@ -28,8 +28,7 @@ class ForResolver {
   void resolveElement(ForElementImpl node, CollectionLiteralContext? context) {
     var forLoopParts = node.forLoopParts;
     void visitBody() {
-      node.body2.resolveElement(_resolver, context);
-      _resolver.popRewrite();
+      _resolver.dispatchCollectionElement(node.body2, context);
     }
 
     if (forLoopParts is ForPartsImpl) {

pkg/analyzer/lib/src/dart/resolver/typed_literal_resolver.dart

@@ -666,8 +666,10 @@ class TypedLiteralResolver {
     CollectionLiteralContext? context,
   ) {
     for (var element in elements) {
-      (element as CollectionElementImpl).resolveElement(_resolver, context);
-      _resolver.popRewrite();
+      _resolver.dispatchCollectionElement(
+        element as CollectionElementImpl,
+        context,
+      );
     }
   }