Skip to content

DT 5.0.0 often crashes when browsing through the thumbnails in LightTable #18137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
redmoon1945 opened this issue Jan 2, 2025 · 18 comments
Open

Comments

@redmoon1945
Copy link

Describe the bug

When using the official AppImage of DT 5.0.0 on Linux Mint 22, it often crashes when browsing through the thumbnails in LightTable. It was OK with 4.8.1 on the same system.

Steps to reproduce

The freeze is not systematic. It may occurs after just the first browsing or 15 minutes later.
Just open DT, and using Page up - Page Down navigate through the thumbnails, changing current folder frequently. Confirming OpenCL is not used.

Expected behavior

We shold never experience a crash for such a basic feature.

Logfile | Screenshot | Screencast

darktable_bt_YATQZ2.txt

Commit

No response

Where did you obtain darktable from?

downloaded from www.darktable.org

darktable version

5.0.0

What OS are you using?

Linux

What is the version of your OS?

Mint 22

Describe your system?

System:
Host: venus Kernel: 6.8.0-51-generic arch: x86_64 bits: 64
Desktop: Cinnamon v: 6.2.9 Distro: Linux Mint 22 Wilma
Machine:
Type: Laptop System: LENOVO product: 21CQ000GUS v: ThinkPad T14s Gen 3
serial:
Mobo: LENOVO model: 21CQ000GUS v: SDK0T76530 WIN
serial: UEFI: LENOVO v: R22ET72W (1.42 )
date: 07/29/2024
Battery:
ID-1: BAT0 charge: 52.9 Wh (100.0%) condition: 52.9/57.0 Wh (92.8%)
CPU:
Info: 8-core AMD Ryzen 7 PRO 6850U with Radeon Graphics [MT MCP]
speed (MHz): avg: 601 min/max: 400/4768
Graphics:
Device-1: AMD Rembrandt [Radeon 680M] driver: amdgpu v: kernel
Device-2: Bison Integrated Camera driver: uvcvideo type: USB
Display: x11 server: X.Org v: 21.1.11 with: Xwayland v: 23.2.6 driver: X:
loaded: amdgpu unloaded: fbdev,modesetting,vesa dri: radeonsi gpu: amdgpu
resolution: 1: 5120x288060Hz 2: 3840x240060Hz
API: OpenGL v: 4.6 compat-v: 4.5 vendor: amd mesa v: 24.0.9-0ubuntu0.3
renderer: AMD Radeon Graphics (radeonsi rembrandt LLVM 17.0.6 DRM 3.57
6.8.0-51-generic)
Network:
Device-1: Qualcomm QCNFA765 Wireless Network Adapter driver: ath11k_pci
Drives:
Local Storage: total: 1.86 TiB used: 1.65 TiB (88.3%)
Info:
Memory: total: 32 GiB note: est. available: 30.13 GiB used: 1.71 GiB (5.7%)
Processes: 403 Uptime: 0m Shell: Bash inxi: 3.3.34

Are you using OpenCL GPU in darktable?

None

If yes, what is the GPU card and driver?

No response

Please provide additional context if applicable. You can attach files too, but might need to rename to .txt or .zip

No response

@redmoon1945
Copy link
Author

Forgot to mention that I tried the "-d" switch to get more debug info that the backtrace, but strangely I have not been able to reproduce the bug this way (effect of stack corruption different ? I dont know). The freeze happens on average 5 min after I open DT and start browsing the thumbnails and changing folder (the only action I do), OpenCL confirmed not used when I look in the Settings.

@Artaga734
Copy link

I can confirm the crashes in the lightable with DT 5.0.0 on Windows 11, when selecting multiple missing files (culled with XnViewMP) to remove them from the thumbnails. Note : I select them with Ctrl+ multiple Click.

This issue was already present in 4.8.1 (it is the reason I upgraded to 5.0.0).

@wpferguson
Copy link
Member

Use the db maintenance lua-script to remove the missing files.

The issue is that you are removing images that darktable knows about (and that have database references) from outside of darktable, so darktable doesn't know if the images are missing because you forgot to mount a drive, or because the user did something ill advised.

If you are going to cull using an external program, then you should probably cull before importing into darktable.

@redmoon1945
Copy link
Author

The bug reported by this issue does not involve selected and removing thumbnails. It just merely browsing the thumbnails (with mouse or page up/down)

@Artaga734
Copy link

Artaga734 commented Jan 6, 2025

@wpferguson There is a button to remove the missing files in LightTable. I will take a look at the lua-script for database maintenance. Sometimes, for whatever reason we might need to remove files from the disk from an already imported library. I understand your point of culling the majority prior to importing the files.

@redmoon1945 The issue might be related to yours in some way (unknown to me) as the symptoms are the same = LightTable crashes. But I think it deserves a separate issue and maybe link it here in case our two issues originate from the same bug.

@wpferguson
Copy link
Member

The remove button in the actions on selected images module, removes the database information, but leaves the files, but it may work.

The script compares the database to the files (not) present and gives you an option to make the database agree with the files.

@Artaga734
Copy link

@wpferguson That is what I want to use indeed. I filed a separate issue here: #18166 with a backtrace.

@Artaga734
Copy link

Back to this original issue of @redmoon1945 I just happened to experience the same crash when scrolling while trying to replicated my other bug. So I can confirm @redmoon1945's specific issue.

@redmoon1945
Copy link
Author

redmoon1945 commented Jan 6, 2025

Thank you Artaga734 to confirm the bug. In my mind this is rather a high priority bug, as it prevents the use of DT 5.0.0. As previously mentioned, I am fully committed to help fix the bug, just tell me what to do. Cheers, we will get it...

@DanielFeld2020
Copy link

I can confirm this bug too. Didn't notice this with DT 4.8.1.

Maybe this helps:

:
(darktable.exe:9828): GLib-CRITICAL **: 10:19:31.797: g_hash_table_lookup: assertion 'hash_table != NULL' failed

(darktable.exe:9828): GLib-CRITICAL **: 10:20:10.775: g_hash_table_lookup: assertion 'hash_table != NULL' failed

(darktable.exe:9828): GLib-CRITICAL **: 10:20:11.378: g_hash_table_lookup: assertion 'hash_table != NULL' failed

(darktable.exe:9828): GLib-CRITICAL **: 10:20:28.042: g_hash_table_lookup: assertion 'hash_table != NULL' failed
Magick: Sorry, can not handle image with PhotometricInterpretation=34892. ().

(darktable.exe:9828): GLib-CRITICAL **: 10:20:28.933: g_hash_table_lookup: assertion 'hash_table != NULL' failed
Magick: Sorry, can not handle image with PhotometricInterpretation=34892. ().

(darktable.exe:9828): GLib-CRITICAL **: 10:20:30.262: g_hash_table_lookup: assertion 'hash_table != NULL' failed

(darktable.exe:9828): GLib-CRITICAL **: 10:20:30.720: g_hash_table_lookup: assertion 'hash_table != NULL' failed
Magick: Sorry, can not handle image with PhotometricInterpretation=34892. ().

(darktable.exe:9828): GLib-CRITICAL **: 10:20:34.260: g_hash_table_lookup: assertion 'hash_table != NULL' failed
Magick: Sorry, can not handle image with PhotometricInterpretation=34892. ().

(darktable.exe:9828): GLib-CRITICAL **: 10:20:35.065: g_hash_table_lookup: assertion 'hash_table != NULL' failed

(darktable.exe:9828): GLib-CRITICAL **: 10:20:37.191: g_hash_table_lookup: assertion 'hash_table != NULL' failed

(darktable.exe:9828): GLib-CRITICAL **: 10:20:42.226: g_hash_table_lookup: assertion 'hash_table != NULL' failed

(darktable.exe:9828): GLib-CRITICAL **: 10:20:42.288: g_hash_table_lookup: assertion 'hash_table != NULL' failed

(darktable.exe:9828): GLib-CRITICAL **: 10:22:00.280: g_hash_table_lookup: assertion 'hash_table != NULL' failed

(darktable.exe:9828): GLib-CRITICAL **: 10:22:00.296: g_hash_table_lookup: assertion 'hash_table != NULL' failed

(darktable.exe:9828): GLib-CRITICAL **: 10:22:00.320: g_hash_table_lookup: assertion 'hash_table != NULL' failed

(darktable.exe:9828): GLib-CRITICAL **: 10:23:18.459: g_hash_table_lookup: assertion 'hash_table != NULL' failed

(darktable.exe:9828): GLib-CRITICAL **: 10:23:48.071: g_ref_count_inc: assertion 'rrc < 0' failed
Magick: caught exception 0xC0000005 "Access violation"...

DT 5.0.0 on Windows 11

@wpferguson
Copy link
Member

(darktable.exe:9828): GLib-CRITICAL **: 10:19:31.797: g_hash_table_lookup: assertion 'hash_table != NULL' failed

This is fixed in master (it's in the image information display) and has nothing to do with the bug submitted by OP.

@wpferguson
Copy link
Member

I am fully committed to help fix the bug, just tell me what to do.

Don't delete images that are known to darktable using external tools. Use darktable to remove (delete from the database, but leave the files intact) or delete (remove from the database and delete the files from disk). If you use external tools to manage the files that darktable knows about, they you've created an instability that can cause darktable to crash.

The DB maintenance script is provided to ensure the file system and database agree, and if not effect repairs.

@MStraeten
Copy link
Collaborator

maybe rename your darktblerc file in your .config/darktable directory to get a default configuration of the application. (This doesn’t affect your library or presets, styles, tags etc.)
Since a lot of session parameters are persisted there this can cause invalid settings especially if no longer existing stuff is referenced there …

@Artaga734
Copy link

@wpferguson OP does not mention any deleted images in this issue

@MStraeten Thanks for that, I just tried this and could not reproduce the issue on my side for now. @redmoon1945 maybe this can help.

@DanielFeld2020
Copy link

Just to make this clear: I didn't delete any pictures outside of DT. It did crash on me while scrolling (with touchpad) in LightTable over a longer time. Unfortunately I couldn't reproduce the problem again with DT 5.0.0 so far.

@wpferguson said there was a fix made in master for the Access violation shown in my previously posted log, though he doesn't think this is related to the OP problem. Well, the log shows that DT did crash while just scrolling in LightTable.

A recent discussion on pixls.us ("Any timeframe to stabilize buggy 5.0.0 ?") speculates on possible database problems due to an previous update as the cause for this bug. I only installed 4.8.1 months before and now updated to 5.0.0 thru Windows installer from darktable.org. I don't run LUA scripts. I didn't manually fiddle with configuration... What could go wrong, how could I check this and if there would be a database problem, what could I do to fix this?

@TurboGit
Copy link
Member

@DanielFeld2020 : We already have seen such issues in the past and it was in most cases:

  • A corrupted RAW that dt tried to read for creating the thumbs for example
  • A format not fully supported (lot of fixes have been made for 5.0 to better check for this)

I don't think this could be a db issue, but we never know.

The "fix" was to find out which image is causing trouble and removing it from darktable. At this point we can then try to reproduce the issue by reimporting the culprit RAW and debug the issue.

@DanielFeld2020
Copy link

@TurboGit Thanks for your answer. I understand that we currently can't do much more without crashes happening again and then hopefully get logs. In my case I can rule out corrupt RAWs and unsupported formats for 99%. I think there still lurkes a bug somewhere in LightTable scrolling. Maybe a timing problem that now shows up with the new touchpad soft scrolling or some memory problem when scrolling thru many pictures. We will see...

Copy link

This issue has been marked as stale due to inactivity for the last 60 days. It will be automatically closed in 300 days if no update occurs. Please check if the master branch has fixed it and report again or close the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants