Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After upgrading to 5.0.0 polish interface language is gone #18079

Open
wnagrodzki opened this issue Dec 26, 2024 · 8 comments
Open

After upgrading to 5.0.0 polish interface language is gone #18079

wnagrodzki opened this issue Dec 26, 2024 · 8 comments
Labels
scope: translation / strings make darktable international

Comments

@wnagrodzki
Copy link

Describe the bug

Polish interface language is gone. I was upgrading from 4.8.1.

Steps to reproduce

  1. Go to Settings
  2. Select General
  3. Try searching for polish in Interface language

Expected behavior

polish should be on the list

Logfile | Screenshot | Screencast

Screenshot 2024-12-26 at 11 17 45

Commit

No response

Where did you obtain darktable from?

downloaded from www.darktable.org

darktable version

5.0.0

What OS are you using?

Mac

What is the version of your OS?

15.2 (24C101)

Describe your system?

MacBook M1.

Are you using OpenCL GPU in darktable?

None

If yes, what is the GPU card and driver?

No response

Please provide additional context if applicable. You can attach files too, but might need to rename to .txt or .zip

No response

@victoryforce
Copy link
Collaborator

polish should be on the list

Polish can be included in the list ONLY if someone with knowledge of Polish translates the text updated to the new release of the program. Outdated translations, the number of untranslated lines of which exceeds a certain threshold, are not included in darktable.

Translation into a certain language is always a contribution to the project of native speakers of this language. @wnagrodzki Wanna contribute?

@wnagrodzki
Copy link
Author

wnagrodzki commented Dec 26, 2024

@victoryforce With pleasure. Would you mind directing me to the parts that lack translation?

Edit:
I followed instructions on https://github.com/darktable-org/darktable/wiki/Translating-darktable but encountered the following issue:

Unescaped left brace in regex is passed through in regex; marked by <-- HERE in m/\${ <-- HERE ?AC_PACKAGE_NAME}?/ at /opt/homebrew/bin/intltool-update line 1193.
Unescaped left brace in regex is passed through in regex; marked by <-- HERE in m/\${ <-- HERE ?PACKAGE}?/ at /opt/homebrew/bin/intltool-update line 1194.
Unescaped left brace in regex is passed through in regex; marked by <-- HERE in m/\${ <-- HERE ?AC_PACKAGE_VERSION}?/ at /opt/homebrew/bin/intltool-update line 1195.
Unescaped left brace in regex is passed through in regex; marked by <-- HERE in m/\${ <-- HERE ?VERSION}?/ at /opt/homebrew/bin/intltool-update line 1196.
Unescaped left brace in regex is passed through in regex; marked by <-- HERE in m/\${ <-- HERE ?AC_PACKAGE_NAME}?/ at /opt/homebrew/bin/intltool-update line 1222.
Unescaped left brace in regex is passed through in regex; marked by <-- HERE in m/\${ <-- HERE ?PACKAGE}?/ at /opt/homebrew/bin/intltool-update line 1223.
Unescaped left brace in regex is passed through in regex; marked by <-- HERE in m/\${ <-- HERE ?AC_PACKAGE_VERSION}?/ at /opt/homebrew/bin/intltool-update line 1224.
Unescaped left brace in regex is passed through in regex; marked by <-- HERE in m/\${ <-- HERE ?VERSION}?/ at /opt/homebrew/bin/intltool-update line 1225.
Unescaped left brace in regex is passed through in regex; marked by <-- HERE in m/\${ <-- HERE ?\w+}?/ at /opt/homebrew/bin/intltool-update line 1226.
can't open ./../build/share/darktable/org.darktable.darktable.desktop.in: No such file or directory at /opt/homebrew/bin/intltool-extract line 212.
xgettext: error while opening "../build/bin/conf_gen.h" for reading: No such file or directory
ERROR: xgettext failed to generate PO template file. Please consult
       error message above if there is any.

Regular expression issues are fixable, but can't open ./../build/share/darktable/org.darktable.darktable.desktop.in: No such file or directory at /opt/homebrew/bin/intltool-extract line 212. seems like a blocker for newcomers. Do you have any advice here?

@MStraeten
Copy link
Collaborator

better use this approach: https://github.com/darktable-org/darktable/wiki/Translations

@victoryforce
Copy link
Collaborator

@wnagrodzki You have already been recommended to use the process where you just need to download two files and run poedit.

I would like to add that for a quality translation you should at least adhere to the following:

  • Be consistent with the already translated part. If the existing translation is made in the lowercase style (like the original text), you should continue like this. You may think that this is not the best style (for example, I eventually changed the Ukrainian translation to normal case), but if you change it, then you need to change the entire translation at once.

  • If possible, check how the translated lines look in the GUI. This is not always realistic to do, but it may allow you to make a better/more correct translation.

  • If you are translating a word or phrase that can occur in many places (i.e. is a term), then it is advisable to check whether it is translated identically in other parts of the GUI.

@wnagrodzki
Copy link
Author

#18087

@ralfbrown ralfbrown added the scope: translation / strings make darktable international label Dec 27, 2024
@wnagrodzki
Copy link
Author

I also updated wiki to include a section on how to test updated translations locally https://github.com/darktable-org/darktable/wiki/Translations#testing-translations

@dymian73
Copy link

dymian73 commented Jan 1, 2025

I am very grateful for the translation into Polish. Has the translation already been added to version 5.0 ?

@MStraeten
Copy link
Collaborator

if it’s complete at freeze date for bugfix release 5.0.1 it will be added then. But you can make use of the testing section @wnagrodzki added to use the current state of the translation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: translation / strings make darktable international
Projects
None yet
Development

No branches or pull requests

5 participants