Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clearly document how to disable placement connection on non-actor services #4044

Open
KrylixZA opened this issue Feb 23, 2024 · 3 comments
Open
Assignees
Labels
content/incorrect-information Content in the docs is incorrect

Comments

@KrylixZA
Copy link
Contributor

Describe the issue

On the page: Dapr arguments and annotations for daprd, CLI, and Kubernetes, it specifies

When the annotation is set and the value is empty, the sidecar does not connect to Placement server. This can be used when there are no actors running in the sidecar.

However it is not completely clear that the value needs to be a single space. Simply putting '' does not work. It needs to be set to ' ' for this to work.

URL of the docs
https://docs.dapr.io/reference/arguments-annotations-overview/

Expected content
The docs should explicitly state that it needs to be set to ' ' in order for it to work and specify this needs to be a single space character.

Screenshots
N/A

Additional context
This is for those wanting to get rid of the 404 /dapr/config issues in their telemetry during application startup.

@KrylixZA KrylixZA added the content/incorrect-information Content in the docs is incorrect label Feb 23, 2024
@KrylixZA
Copy link
Contributor Author

This does seem to be largely a Helm thing, not a Dapr thing. But it's worth putting in the docs.

@msfussell
Copy link
Member

@KrylixZA Were you setting this annotation via Helm or some other way? Making sure our guidance for the approach is consistent.

@KrylixZA
Copy link
Contributor Author

KrylixZA commented Mar 4, 2024

@msfussell Yeah using Helm to set pod annotations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content/incorrect-information Content in the docs is incorrect
Projects
None yet
Development

No branches or pull requests

3 participants