-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenTelemetry spec v1.10 that Dapr uses needs to be updated to v1.25 #7703
Labels
Milestone
Comments
theperm
changed the title
OpenTelemetry spec
OpenTelemetry spec Dapr uses is outdated v1.10
Apr 18, 2024
theperm
changed the title
OpenTelemetry spec Dapr uses is outdated v1.10
OpenTelemetry spec v1.10 that Dapr uses needs to be updated to v1.25
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In what area(s)?
/area runtime
What version of Dapr?
1.13.2
Expected Behavior
The current OpenTelemetry specification is v1.25 and compliance with this version is required with some Observability platforms like Cisco Cloud Observability or else they do not understand how to visualise endpoint flow maps.
Changes to the v1.25 specification of trace spans for http server and client contexts state that the spans SHOULD contain the attributes :
http.request.method
server.address
server.port
url.full
There are additional attributes recommended and advisories for handling previous specifications so it would be worthwhile reviewing the implementation and the new specification and supporting some of the recommended attributes as well.
HTTP Sever: The following attributes can be important for making sampling decisions and SHOULD be provided at span creation time (if provided at all):
url.path
url.scheme
server.port
url.query
client.address
server.address
user_agent.original
http.request.header.
http.route MUST be provided at span creation time if and only if it's already available. If it becomes available after span starts, instrumentation MUST populate it anytime before span ends.
See v1.25.0/docs/http/http-spans.md
Additionally these attributes are required on all OpenTelemetry data:
Actual Behavior
http.request.method is missing from http client span attributes
server.address is missing from http client span attributes
server.port is missing from http client span attributes
url.full is missing from http client span attributes
http.request.method is missing from http client span attributes
http.request.method is missing from http server t span attributes
server.address is missing from http server span attributes
server.port is missing from http server span attributes
url.path is missing from http server span attributes
url.scheme is missing from http server span attributes
Steps to Reproduce the Problem
Collect and trace info from Dapr and inspect the span attributes
Release Note
RELEASE NOTE: UPDATE OpenTelemetry specification to v1.25
The text was updated successfully, but these errors were encountered: