Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Clone] Error Standardization: Secrets API #7690

Open
8 tasks
pglushko opened this issue Apr 11, 2024 · 1 comment · May be fixed by #7691
Open
8 tasks

[Clone] Error Standardization: Secrets API #7690

pglushko opened this issue Apr 11, 2024 · 1 comment · May be fixed by #7691
Assignees

Comments

@pglushko
Copy link

Richer errors in Dapr for the Secrets API.

Original #7484

Scope of work
Choose 5-10 errors in the Secrets API to enrich. Ideally, cover as many errors as possible from the API.
Follow the steps outlined in this README for each error being updated
Definition of done

  • Update 5-10 errors in the Secrets API
  • Update the unit tests, if necessary
  • Write integration tests to cover each updated errors

Keep in mind
Unless a major version is being released and there is a solid reason for introducing backwards incompatibility, we can't change the API, meaning the HTTP and gRPC status codes, and the error codes must stay the same. An exception to this is the gRPC StatusCode.UNKNOWN which should be converted to a specific status.

See the kit errors pkg README for another usage example. For each error being updated, you can use the following helper functions to add error details, see the kit errors pkg for more details:

  • WithHelpLink()
  • WithHelp()
  • WithErrorInfo() - Required
  • WithFieldViolation()
  • WithDetails()

Reference PRs
Existing error standardization for:

#7257
#7322

@pglushko
Copy link
Author

/assign

@pglushko pglushko linked a pull request Apr 11, 2024 that will close this issue
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant