Skip to content
This repository was archived by the owner on Mar 14, 2020. It is now read-only.

background image not loading #15

Closed
Aid19801 opened this issue Feb 15, 2019 · 1 comment
Closed

background image not loading #15

Aid19801 opened this issue Feb 15, 2019 · 1 comment

Comments

@Aid19801
Copy link

Hey,

Saw a few other similar issues but the solutions for them don't seem to fix this.

let props = {
    imageSrc: 'https://www.alm.com/wp-content/uploads/2017/10/NYC_Contact-Us-Page-Form-image.jpg" />',
    color: '#ffff33',
    minHeight: '14vh',
}

const LargeHero = () => (
    <LazyHero {...props}>
        <h1>Generic Startup Hype Headline</h1>
    </LazyHero>
)

I also tried with your imageSrc from docs imageSrc="https://unsplash.it/2000/1000" and also no joy.

Changing minHeight works, but nothing around background image or color can be changed.

Versions:

"react": "^16.8.1",
"react-lazy-hero": "2.0.0",
"styled-components": "4.0.0",

@Aid19801
Copy link
Author

update: not sure why but i found that cloning your repo, then adding in my own app, piece-by-piece, to your example website/src files - i was able to establish that the image disappeared when i brought in my own App.css root file. This is from Create React App and i'd put in display: flex to manage the stack of components with flexbox.

Once i removed display: flex the image came back with color overlay too.

Hopefully this proves useful for someone else. 🤓

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant