Using ios <17 and >=17 together is generating a huge amount of logging

[joao-borges-miw]

Describe the bug
While having an iPhone with iOS 16 or 15 connected simultaneously with an iOS 17 or 18, the tunnel process output has a message every second saying it can't start the tunnel for the 16. This message escalates when adding more older devices connected with the 17 and 18 ones.

{"error":"manualPairingTunnelStart: unsupported iOS version 16.6.0","level":"warning","msg":"failed to start tunnel","time":"2024-12-03T10:09:31-08:00","udid":"00008020-000264E9026A002E"}

To Reproduce
Steps to reproduce the behavior:

1. Connect both iOS 17/18 and 15/16 devices to the same machine
2. Start the tunnel with ios tunnel start

Expected behavior
Tunnel output messages do not contain error messages that are not an error, just a regular usage condition.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

• OS: any OS

Smartphone (please complete the following information):

• Device: iPhone XR (ios 16), 13 (ios 17) and 14 (ios 18)

[l54808821]

I have the same problem. Help

[kazzmir]

Here is a patch that blacklists a device from being tunneled after the first attempt at starting a tunnel for that device fails.

diff --git a/ios/tunnel/tunnel_api.go b/ios/tunnel/tunnel_api.go
index 84e2f56..09d8574 100644
--- a/ios/tunnel/tunnel_api.go
+++ b/ios/tunnel/tunnel_api.go
@@ -222,6 +222,7 @@ type TunnelManager struct {
        userspaceTUN         bool
        closeOnce            sync.Once
        portOffset           int
+    blacklisted          map[string]struct{}
 }
 
 // NewTunnelManager creates a new TunnelManager instance for setting up device tunnels for all connected devices
@@ -235,6 +236,7 @@ func NewTunnelManager(pm PairRecordManager, userspaceTUN bool) *TunnelManager {
                startTunnelTimeout: 10 * time.Second,
                userspaceTUN:       userspaceTUN,
                portOffset:         1,
+        blacklisted:        make(map[string]struct{}),
        }
 }
 
@@ -277,8 +279,14 @@ func (m *TunnelManager) UpdateTunnels(ctx context.Context) error {
        if err != nil {
                return fmt.Errorf("UpdateTunnels: failed to get list of devices: %w", err)
        }
+
        for _, d := range devices.DeviceList {
                udid := d.Properties.SerialNumber
+
+        if _, exists := m.blacklisted[udid]; exists {
+            continue
+        }
+
                if _, exists := localTunnels[udid]; exists {
                        continue
                }
@@ -291,6 +299,7 @@ func (m *TunnelManager) UpdateTunnels(ctx context.Context) error {
                        log.WithField("udid", udid).
                                WithError(err).
                                Warn("failed to start tunnel")
+            m.blacklisted[udid] = struct{}{}
                        continue
                }
                m.mux.Lock()

With this patch, you will see one error about not being able to start a tunnel on some device, but then no more log messages appear for that device.