New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] parent_ids
of GitLab MR commits is always an empty array
#1418
Comments
@frantic1048 — I’m not sure DangerJS can fix this right? Since the upstream issue is 4 years old?… What would you like to do here? |
@fbartho Here are 2 ways I found to workaround it, but both of them have their own drawbacks. I'm currently using the second workaround to perform checks around
Because of the drawbacks, I'm not promoting any of the workarounds into danger-js. Just sharing my findings here in case anyone else is facing the same issue. For danger-js, I think it's better to add some warning messages(through comments on the type definition) about |
Describe the bug
To Reproduce
This MR compares results from danger's
parent_ids
and git CLI(the expected result).https://gitlab.com/frantic1048/danger-empty-parent-ids/-/merge_requests/1
Expected behavior
A commit's
parent_ids
should contain all parent ids.Your Environment
Additional context
This is actually an upstream issue of GitLab: Commit parent IDs list is empty in some REST API's.
To ensure a smoother experience, we may implement a workaround in danger.
The text was updated successfully, but these errors were encountered: