Don't apply delta to enormously large buffers #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I'm running your commit locally. I might be slightly slow to review and merge due to day job. |
I'm not seeing any color when it disables delta. Do you see the usual magit colors? |
I still can see Magit's normal red and green colors, for example this commit: dandavison/delta@79979c2
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces new variable -
magit-delta-max-lines, set to 1000 by default. If buffer lines exceeded this value, then default magit highlighting used instead of delta to keep emacs responsive. Regarding default value -1000just works for me:). It tooks 2-3 seconds to display diff on Core-I7, so maybe it should be decreased. This MR fixes #26